Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 938533002: Avoid redrawing Display when not damaged. (Closed)

Created:
5 years, 10 months ago by jbauman
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid redrawing Display when not damaged. There's no need to do a draw (or swap) if the current frame has no damage, there's no copy request pending, and there's no new latency info. Committed: https://crrev.com/c00b836b38c4651e8513a286a0ab03f914a35c78 Cr-Commit-Position: refs/heads/master@{#317208}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -15 lines) Patch
M cc/cc_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/display.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/surfaces/display.cc View 1 chunk +36 lines, -15 lines 0 comments Download
A cc/surfaces/display_unittest.cc View 1 2 1 chunk +239 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jbauman
5 years, 10 months ago (2015-02-19 00:58:00 UTC) #2
jamesr
tests? lgtm otherwise
5 years, 10 months ago (2015-02-19 01:23:49 UTC) #3
jbauman
On 2015/02/19 01:23:49, jamesr wrote: > tests? > > lgtm otherwise Ok, added some new ...
5 years, 10 months ago (2015-02-20 00:07:26 UTC) #5
jamesr
thanks, tests lgtm as well (and I think they'll help us not accidentally delete one ...
5 years, 10 months ago (2015-02-20 00:10:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938533002/20001
5 years, 10 months ago (2015-02-20 00:13:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/3777)
5 years, 10 months ago (2015-02-20 00:27:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938533002/40001
5 years, 10 months ago (2015-02-20 00:34:11 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-20 01:31:00 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 01:31:25 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c00b836b38c4651e8513a286a0ab03f914a35c78
Cr-Commit-Position: refs/heads/master@{#317208}

Powered by Google App Engine
This is Rietveld 408576698