Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 938473002: [New Tab Page] Remove title iframe 1px dead zone. (Closed)

Created:
5 years, 10 months ago by huangs
Modified:
5 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[New Tab Page] Remove title iframe 1px dead zone. Material Design tile titles are 15px high, but on some (if not all) platforms the natural height of title content is 14px high. This creates a click "dead zone" on the tile. This CL forces content height to be 100% to remove the dead zone. BUG=459301 Committed: https://crrev.com/63731566d0d8e2e44e3dc0618c17f2403d99668d Cr-Commit-Position: refs/heads/master@{#317633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/local_ntp/most_visited_title.css View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
huangs
PTAL.
5 years, 10 months ago (2015-02-17 22:18:28 UTC) #2
Mathieu
lgtm lgtm
5 years, 10 months ago (2015-02-17 22:23:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938473002/1
5 years, 10 months ago (2015-02-17 22:25:26 UTC) #5
huangs
Verified that discrepancy I found (where the bug disappears) was due to Remote Desktop rendering ...
5 years, 10 months ago (2015-02-23 19:58:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938473002/1
5 years, 10 months ago (2015-02-23 19:59:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 20:00:12 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:00:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63731566d0d8e2e44e3dc0618c17f2403d99668d
Cr-Commit-Position: refs/heads/master@{#317633}

Powered by Google App Engine
This is Rietveld 408576698