apps/load_and_launch_browsertest.cc - Issue 938453002: Remove base::WaitForSingleProcess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/load_and_launch_browsertest.cc

Issue 938453002: Remove base::WaitForSingleProcess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cl format :( Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: apps/load_and_launch_browsertest.cc

diff --git a/apps/load_and_launch_browsertest.cc b/apps/load_and_launch_browsertest.cc

index 9432420ffe6b0e7302db1d845dfbd352e731edfe..fc95daec61bc75a6fdd0be387e65942f9d00ab93 100644

--- a/apps/load_and_launch_browsertest.cc

+++ b/apps/load_and_launch_browsertest.cc

@@ -62,8 +62,10 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,

ASSERT_TRUE(process.IsValid());

ASSERT_TRUE(launched_listener.WaitUntilSatisfied());

- ASSERT_TRUE(base::WaitForSingleProcess(process.Handle(),

- TestTimeouts::action_timeout()));

+ int exit_code;

+ ASSERT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_timeout(),

+ &exit_code));

+ ASSERT_EQ(0, exit_code);

}

// TODO(jackhou): Enable this test once it works on OSX. It currently does not

@@ -102,8 +104,10 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,