src/preparser.cc - Issue 938443002: [es6] implement spread calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.cc

Issue 938443002: [es6] implement spread calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Eagerly iterate spread expressions, make parser more complicated, simplify harmony-spread Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.cc

diff --git a/src/preparser.cc b/src/preparser.cc

index 8c61b7db85159a6405abada086faee0c6b535767..d5d1b6fa6c34f1022392271386522ee748dc9cb2 100644

--- a/src/preparser.cc

+++ b/src/preparser.cc

@@ -1017,7 +1017,11 @@ PreParser::Expression PreParser::ParseV8Intrinsic(bool* ok) {

}

// Allow "eval" or "arguments" for backward compatibility.

ParseIdentifier(kAllowEvalOrArguments, CHECK_OK);

- ParseArguments(ok);

+ Scanner::Location spread_pos;

+ ParseArguments(&spread_pos, ok);

+ // TODO(caitp): support intrinsics

+ DCHECK(!spread_pos.IsValid());

return Expression::Default();

}