src/hydrogen.cc - Issue 938443002: [es6] implement spread calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 938443002: [es6] implement spread calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add DCHECK() to prevent intrinsics from being called with spread operator Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 05a8618fce3d65fb30d8d561f46466b02477acc8..7b280953108f2cbe518c17b47c9a0debbdee61a8 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -11143,6 +11143,11 @@ void HOptimizedGraphBuilder::HandleLiteralCompareNil(CompareOperation* expr,

}

+void HOptimizedGraphBuilder::VisitSpreadOperation(SpreadOperation* expr) {

+ Visit(expr->expression());

HInstruction* HOptimizedGraphBuilder::BuildThisFunction() {

// If we share optimized code between different closures, the

// this-function is not a constant, except inside an inlined body.