Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: src/preparser.cc

Issue 938443002: [es6] implement spread calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add construct support, clean out some gunk Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <cmath> 5 #include <cmath>
6 6
7 #include "src/allocation.h" 7 #include "src/allocation.h"
8 #include "src/base/logging.h" 8 #include "src/base/logging.h"
9 #include "src/conversions-inl.h" 9 #include "src/conversions-inl.h"
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 999 matching lines...) Expand 10 before | Expand all | Expand 10 after
1010 PreParser::Expression PreParser::ParseV8Intrinsic(bool* ok) { 1010 PreParser::Expression PreParser::ParseV8Intrinsic(bool* ok) {
1011 // CallRuntime :: 1011 // CallRuntime ::
1012 // '%' Identifier Arguments 1012 // '%' Identifier Arguments
1013 Expect(Token::MOD, CHECK_OK); 1013 Expect(Token::MOD, CHECK_OK);
1014 if (!allow_natives()) { 1014 if (!allow_natives()) {
1015 *ok = false; 1015 *ok = false;
1016 return Expression::Default(); 1016 return Expression::Default();
1017 } 1017 }
1018 // Allow "eval" or "arguments" for backward compatibility. 1018 // Allow "eval" or "arguments" for backward compatibility.
1019 ParseIdentifier(kAllowEvalOrArguments, CHECK_OK); 1019 ParseIdentifier(kAllowEvalOrArguments, CHECK_OK);
1020 ParseArguments(ok); 1020 Scanner::Location spread_pos;
1021 ParseArguments(&spread_pos, ok);
arv (Not doing code reviews) 2015/02/18 15:07:06 Does this work?
caitp (gmail) 2015/02/18 15:32:08 No --- In the other patch I was throwing an error
arv (Not doing code reviews) 2015/02/18 15:36:54 Maybe a DCHECK for now then?
1021 1022
1022 return Expression::Default(); 1023 return Expression::Default();
1023 } 1024 }
1024 1025
1025 #undef CHECK_OK 1026 #undef CHECK_OK
1026 1027
1027 1028
1028 } } // v8::internal 1029 } } // v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698