Add methods for finding object by its snapshot id and id for an object

Add methods for finding object by its snapshot id and id for an object

Object<-->id mapping doesn't depend on a particular snapshot, actually same object may appear in several heap snapshots. The API for converting between id and heap object should be provided by HeapProfiler itself. There is already GetObjectId method which I extended with FindObjectById/ClearObjectIds. As the next step I'm going to deprecate and remove HeapGraphNode::GetHeapValue.

BUG=chromium:324769
LOG=N
R=alph@chromium.org, hpayer@chromium.org, mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18334

[alph, 2013-12-04 08:39:37]

lgtm

https://codereview.chromium.org/93843004/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/93843004/diff/1/src/api.cc#newcode7500
src/api.cc:7500: 
nit: add an empty line

https://codereview.chromium.org/93843004/diff/1/test/cctest/test-heap-profile...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/93843004/diff/1/test/cctest/test-heap-profile...
test/cctest/test-heap-profiler.cc:1067:
heap_profiler->StopTrackingHeapObjects();
Maybe force a GC here to make the objects move.

[yurys, 2013-12-04 08:56:32]

https://codereview.chromium.org/93843004/diff/1/src/api.cc#newcode7500
src/api.cc:7500:
nit: add an empty line

Done.

https://codereview.chromium.org/93843004/diff/1/test/cctest/test-heap-profile...
test/cctest/test-heap-profiler.cc:1067:
heap_profiler->StopTrackingHeapObjects();
Maybe force a GC here to make the objects move.

Done.

[yurys, 2013-12-06 12:39:17]

Hannes or Michael, can you do OWNER review please?

[Michael Starzinger, 2013-12-09 10:53:54]

LGTM (rubber-stamped).

[Hannes Payer (out of office), 2013-12-09 18:53:28]

lgtm

[yurys, 2013-12-18 08:17:12]

Committed patchset #5 manually as r18334 (presubmit successful).