Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: dart/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

Issue 938413002: Work around Safari for-in bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r43958. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
diff --git a/dart/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart b/dart/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
index ae053a198240ea4c5c64582a17befe21e4e12937..c59517884560e730e459013cddcc717afcb9498f 100644
--- a/dart/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
+++ b/dart/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
@@ -57,11 +57,12 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
function processClassData(cls, descriptor, processedClasses) {
var newDesc = {};
var previousProperty;
- for (var property in descriptor) {
- if (!hasOwnProperty.call(descriptor, property)) continue;
+ var properties = Object.keys(descriptor);
+ for (var i = 0; i < properties.length; i++) {
+ var property = properties[i];
var firstChar = property.substring(0, 1);
if (property === "static") {
- processStatics(#embeddedStatics[cls] = descriptor[property],
+ processStatics(#embeddedStatics[cls] = descriptor[property],
processedClasses);
} else if (firstChar === "+") {
mangledNames[previousProperty] = property.substring(1);
@@ -135,8 +136,9 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
// TODO(zarah): Remove empty else branches in output when if(#hole) is false.
jsAst.Statement processStatics = js.statement('''
function processStatics(descriptor, processedClasses) {
- for (var property in descriptor) {
- if (!hasOwnProperty.call(descriptor, property)) continue;
+ var properties = Object.keys(descriptor);
+ for (var i = 0; i < properties.length; i++) {
+ var property = properties[i];
if (property === "${namer.classDescriptorProperty}") continue;
var element = descriptor[property];
var firstChar = property.substring(0, 1);
@@ -407,7 +409,8 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
#trivialNsmHandlers;
- for (var cls in processedClasses.pending) finishClass(cls);
+ var properties = Object.keys(processedClasses.pending);
+ for (var i = 0; i < properties.length; i++) finishClass(properties[i]);
}
}''', {'allClasses': allClassesAccess,
'debugFastObjects': DEBUG_FAST_OBJECTS,
« no previous file with comments | « dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698