Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

Issue 938413002: Work around Safari for-in bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
diff --git a/dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart b/dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
index e34319e58c2b6d8aee4ed75c3b8490822bad867e..421ab07eb83a1b19cbe54ef8117b83a7a292c206 100644
--- a/dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
+++ b/dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
@@ -2234,6 +2234,7 @@ class JsClosureMirror extends JsInstanceMirror implements ClosureMirror {
disableTreeShaking();
// TODO(ahe): What about optional parameters (named or not).
String callPrefix = "${JS_GET_NAME(JsGetName.CALL_PREFIX)}\$";
+ // TODO(ahe): Use of for-in.
var extractCallName = JS('', r'''
function(reflectee) {
for (var property in reflectee) {

Powered by Google App Engine
This is Rietveld 408576698