Work around Safari for-in bug.

dart/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart._js_mirrors;
 
 import 'dart:_js_embedded_names' show
     JsGetName,
     ALL_CLASSES,
     LAZIES,
@@ skipping 2218 matching lines @@
     String cacheName = Primitives.mirrorFunctionCacheName;
     JsMethodMirror cachedFunction;
     // TODO(ahe): Restore caching.
     //= JS('JsMethodMirror|Null', r'#.constructor[#]', reflectee, cacheName);
     if (cachedFunction != null) return cachedFunction;
     disableTreeShaking();
     // TODO(ahe): What about optional parameters (named or not).
     String callPrefix = "${JS_GET_NAME(JsGetName.CALL_PREFIX)}\$";
     var extractCallName = JS('', r'''
 function(reflectee) {
-  for (var property in reflectee) {
-    if (# == property.substring(0, #) &&
-        property[#] >= '0' &&
-        property[#] <= '9') return property;
+  var properties = Object.keys(reflectee);

[ahe, 2015/02/20 14:32:16]

I'm pretty sure I was too lazy to use hasOwnProperty here.

[floitsch, 2015/02/20 16:08:03]

Change LGTM. The call-properties are stored on the reflectee directly.

[ahe, 2015/02/20 18:05:19]

Turns out that the property is stored on the prototype, and D8 can't find it
with Object.getOwnPropertyNames :-(

However, this works:

Object.keys(reflectee.constructor.prototype)

But now I'm scared about Chrome/V8 having issues with
Object.getOwnPropertyNames. Good thing Object.keys seem to work across the
board.







Not looking forward to seeing how this works on IE  D:

+  for (var i = 0; i < properties.length; i++) {
+    var property = properties[i];
+    if (#callPrefix == property.substring(0, #callPrefix_length) &&
+        property[#callPrefix_length] >= '0' &&
+        property[#callPrefix_length] <= '9') return property;
   }
   return null;
 }
-''', callPrefix, callPrefix.length, callPrefix.length, callPrefix.length);
+''', { 'callPrefix': callPrefix, 'callPrefix_length': callPrefix.length });
     String callName = JS('String|Null', '#(#)', extractCallName, reflectee);
     if (callName == null) {
       throw new RuntimeError('Cannot find callName on "$reflectee"');
     }
     // TODO(floitsch): What about optional parameters?
     int parameterCount = int.parse(callName.split(r'$')[1]);
     if (reflectee is BoundClosure) {
       var target = BoundClosure.targetOf(reflectee);
       var self = BoundClosure.selfOf(reflectee);
       var name = mangledNames[BoundClosure.nameOf(reflectee)];
@@ skipping 770 matching lines @@
   // have a part (following a '.') that starts with '_'.
   const int UNDERSCORE = 0x5f;
   if (name.isEmpty) return true;
   int index = -1;
   do {
     if (name.codeUnitAt(index + 1) == UNDERSCORE) return false;
     index = name.indexOf('.', index + 1);
   } while (index >= 0 && index + 1 < name.length);
   return true;
 }