Issue 9384: UploadDataStream::Reset should call FillBuf to return...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9384: UploadDataStream::Reset should call FillBuf to return... (Closed)

Created:
12 years, 1 month ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
jungshik, darin (slow to review), eroman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove the UploadDataStream::Reset method. Instead, rewind an UploadDataStream by recreating the object. Fix a bug in MockTCPClientSocket::Write. It needs to increment write_index_. Add two DCHECKs to simulate the DCHECKS in SSLClientSocketWin::DoPayloadEncrypt. Add a unit test. R=darin,eroman BUG=4062 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4819

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -22 lines)			Patch
M	net/base/upload_data_stream.h	View	1 2 3 4	2 chunks	+1 line, -4 lines	0 comments	Download
M	net/base/upload_data_stream.cc	View	1 2 3 4	3 chunks	+7 lines, -12 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View	2 3 4	1 chunk	+6 lines, -2 lines	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	1 2 3 4	6 chunks	+95 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

wtc

I verified that the only callers of UploadDataStream::Reset are the UploadDataStream constructor and HttpNetworkTransaction::ShouldResendRequest. So ...

12 years, 1 month ago (2008-11-05 01:44:37 UTC) #1

wtc

Darin wrote: > Maybe we should just remove the Reset function and instead > create ...

12 years, 1 month ago (2008-11-05 01:52:41 UTC) #2

LGTM

Expand Messages | Collapse Messages