Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 938383002: Files.app: Add focus feedback on dialog footer. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add focus feedback on dialog footer. Added rounded focus ring for controls on dialog footer. Tab order should be reconsidered later as accessibility improvement. BUG=402344 TEST=manually tested Committed: https://crrev.com/ff372678a3c46ee4522375964fb764785a3eff70 Cr-Commit-Position: refs/heads/master@{#317293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
PTAL. Thanks!
5 years, 10 months ago (2015-02-20 11:01:01 UTC) #2
hirono
lgtm!
5 years, 10 months ago (2015-02-20 11:03:50 UTC) #3
fukino
Thanks!
5 years, 10 months ago (2015-02-20 11:06:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938383002/1
5 years, 10 months ago (2015-02-20 11:09:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 11:35:09 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 11:36:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff372678a3c46ee4522375964fb764785a3eff70
Cr-Commit-Position: refs/heads/master@{#317293}

Powered by Google App Engine
This is Rietveld 408576698