android: Refactor function name template in JNI generator.

android: Refactor function name template in JNI generator.

Factor out the code which generates the native export stub name for a
given native function, previously duplicated in two places, and also use
it in a third place: when generating the table of method registrations.
This will allow the table to be generated even when in native export
mode, as previously the table referred to the default name which is not
defined when using native exports.

BUG=442327
Committed: https://crrev.com/37d21163c4d4d4079747a681b069d124b373d58f
Cr-Commit-Position: refs/heads/master@{#317302}

[Torne, 2015-02-20 10:34:23]

torne@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Torne, 2015-02-20 10:34:24]

This doesn't change any of the output, the golden tests all still pass.

[rmcilroy, 2015-02-20 10:56:02]

lgtm, thanks for the cleanup.

https://codereview.chromium.org/938373002/diff/1/base/android/jni_generator/j...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/938373002/diff/1/base/android/jni_generator/j...
base/android/jni_generator/jni_generator.py:1038: def GetStubName(self, native):
could you add a comment to explain what the StubName represents

[Torne, 2015-02-20 11:39:54]

New patchsets have been uploaded after l-g-t-m from rmcilroy@chromium.org

[Torne, 2015-02-20 11:40:11]

On 2015/02/20 10:56:02, rmcilroy wrote:
> lgtm, thanks for the cleanup.
> 
>
https://codereview.chromium.org/938373002/diff/1/base/android/jni_generator/j...
> File base/android/jni_generator/jni_generator.py (right):
> 
>
https://codereview.chromium.org/938373002/diff/1/base/android/jni_generator/j...
> base/android/jni_generator/jni_generator.py:1038: def GetStubName(self,
native):
> could you add a comment to explain what the StubName represents

Added a docstring with a short explanation.

[Torne, 2015-02-20 11:40:14]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2015-02-20 11:40:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938373002/20001

[commit-bot: I haz the power, 2015-02-20 12:38:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-20 12:38:25]

Patchset 2 (id:??) landed as
https://crrev.com/37d21163c4d4d4079747a681b069d124b373d58f
Cr-Commit-Position: refs/heads/master@{#317302}