Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: sandbox/linux/services/proc_util.h

Issue 938223004: Linux sandbox: better APIs with /proc/ arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix invalid proc_fd_ usage. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/services/namespace_sandbox_unittest.cc ('k') | sandbox/linux/services/proc_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/services/proc_util.h
diff --git a/sandbox/linux/services/proc_util.h b/sandbox/linux/services/proc_util.h
index 74388f8036c61e235e297b2e22473892d3b18d4c..bc14c5ef2ae6ed6af416f0b5fb6bf6d5d51062a5 100644
--- a/sandbox/linux/services/proc_util.h
+++ b/sandbox/linux/services/proc_util.h
@@ -15,7 +15,7 @@ class SANDBOX_EXPORT ProcUtil {
public:
// Returns the number of file descriptors in the current process's FD
// table, excluding |proc_fd|, which should be a file descriptor for
- // /proc.
+ // /proc/.
static int CountOpenFds(int proc_fd);
// Checks whether the current process has any directory file descriptor open.
@@ -24,16 +24,14 @@ class SANDBOX_EXPORT ProcUtil {
// DropFileSystemAccess().
// Sometimes it's useful to call HasOpenDirectory() after file system access
// has been dropped. In this case, |proc_fd| should be a file descriptor to
- // /proc. The file descriptor in |proc_fd| will be ignored by
+ // /proc/. The file descriptor in |proc_fd| will be ignored by
// HasOpenDirectory() and remains owned by the caller. It is very important
// for the caller to close it.
- // If /proc is available, |proc_fd| can be passed as -1.
- // If |proc_fd| is -1 and /proc is not available, this function will return
- // false.
- static bool HasOpenDirectory(int proc_fd);
+ static bool HasOpenDirectory(int proc_fd) WARN_UNUSED_RESULT;
+ static bool HasOpenDirectory() WARN_UNUSED_RESULT;
- // Open /proc/self/task/ or crash if it cannot.
- static base::ScopedFD OpenProcSelfTask();
+ // Open /proc/ or crash if not possible.
+ static base::ScopedFD OpenProc();
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(ProcUtil);
« no previous file with comments | « sandbox/linux/services/namespace_sandbox_unittest.cc ('k') | sandbox/linux/services/proc_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698