Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: sandbox/linux/seccomp-bpf/sandbox_bpf.h

Issue 938223004: Linux sandbox: better APIs with /proc/ arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix invalid proc_fd_ usage. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/sandbox_init.h ('k') | sandbox/linux/seccomp-bpf/sandbox_bpf.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/seccomp-bpf/sandbox_bpf.h
diff --git a/sandbox/linux/seccomp-bpf/sandbox_bpf.h b/sandbox/linux/seccomp-bpf/sandbox_bpf.h
index e46889b14fff9b9a01ab835c2844098056d6c807..96cceb56480b7f6be4bfb158c4439d524c8a7318 100644
--- a/sandbox/linux/seccomp-bpf/sandbox_bpf.h
+++ b/sandbox/linux/seccomp-bpf/sandbox_bpf.h
@@ -64,14 +64,14 @@ class SANDBOX_EXPORT SandboxBPF {
// combined policy. So, it should only be used if there are no alternatives.
bool StartSandbox(SeccompLevel level) WARN_UNUSED_RESULT;
- // The sandbox needs to be able to access files in "/proc/self/task/". If
+ // The sandbox needs to be able to access files in "/proc/self/". If
// this directory is not accessible when "StartSandbox()" gets called, the
// caller must provide an already opened file descriptor by calling
- // "SetProcTaskFd()".
+ // "SetProcFd()".
// The sandbox becomes the new owner of this file descriptor and will
// close it when "StartSandbox()" executes or when the sandbox object
// disappears.
- void SetProcTaskFd(base::ScopedFD proc_task_fd);
+ void SetProcFd(base::ScopedFD proc_fd);
// Checks whether a particular system call number is valid on the current
// architecture.
@@ -106,7 +106,7 @@ class SANDBOX_EXPORT SandboxBPF {
// been configured with SetSandboxPolicy().
void InstallFilter(bool must_sync_threads);
- base::ScopedFD proc_task_fd_;
+ base::ScopedFD proc_fd_;
bool sandbox_has_started_;
scoped_ptr<bpf_dsl::Policy> policy_;
« no previous file with comments | « content/public/common/sandbox_init.h ('k') | sandbox/linux/seccomp-bpf/sandbox_bpf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698