sandbox/linux/services/namespace_sandbox_unittest.cc - Issue 938223004: Linux sandbox: better APIs with /proc/ arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/services/namespace_sandbox_unittest.cc

Issue 938223004: Linux sandbox: better APIs with /proc/ arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/linux/services/namespace_sandbox_unittest.cc

diff --git a/sandbox/linux/services/namespace_sandbox_unittest.cc b/sandbox/linux/services/namespace_sandbox_unittest.cc

index 91e1db925d65165dedb5cf057727790ed10db061..8bb0bff83b7027d86d8b8e08ae82e0ea7ddd8c5a 100644

--- a/sandbox/linux/services/namespace_sandbox_unittest.cc

+++ b/sandbox/linux/services/namespace_sandbox_unittest.cc

@@ -21,6 +21,7 @@

#include "base/test/multiprocess_test.h"

#include "sandbox/linux/services/credentials.h"

#include "sandbox/linux/services/namespace_utils.h"

+#include "sandbox/linux/services/proc_util.h"

#include "sandbox/linux/tests/unit_tests.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "testing/multiprocess_func_list.h"

@@ -85,7 +86,7 @@ TEST_F(NamespaceSandboxTest, BasicUsage) {

MULTIPROCESS_TEST_MAIN(ChrootMe) {

CHECK(!RootDirectoryIsEmpty());

CHECK(sandbox::Credentials::MoveToNewUserNS());

- CHECK(sandbox::Credentials::DropFileSystemAccess());

+ CHECK(sandbox::Credentials::DropFileSystemAccess(ProcUtil::OpenProc().get()));

CHECK(RootDirectoryIsEmpty());

return 0;

}