|
|
Created:
5 years, 10 months ago by Dirk Pranke Modified:
5 years, 10 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll src/third_party/ffmpeg d4b1674:f5698b4
Summary of changes available at:
https://chromium.googlesource.com/chromium/third_party/ffmpeg/+log/d4b1674..f5698b4
BUG=344767
Committed: https://crrev.com/176685b64deddd41f1b4ac40083ad24bc17af564
Cr-Commit-Position: refs/heads/master@{#317706}
Patch Set 1 #Messages
Total messages: 20 (9 generated)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938223003/1
sandersd@chromium.org changed reviewers: + sandersd@chromium.org
I would prefer using the roll-deps tool to generate the CL description. lgtm.
The CQ bit was unchecked by dpranke@chromium.org
On 2015/02/23 23:49:33, sandersd wrote: > I would prefer using the roll-deps tool to generate the CL description. > > lgtm. Oh, sorry, I didn't know such a thing existed. Will re-do.
On 2015/02/23 23:50:20, Dirk Pranke wrote: > On 2015/02/23 23:49:33, sandersd wrote: > > I would prefer using the roll-deps tool to generate the CL description. > > > > lgtm. > > Oh, sorry, I didn't know such a thing existed. Will re-do. It's not important enough to be worth re-doing all the trybots, it just makes it easy to find out what new patches are in the roll.
On 2015/02/23 23:51:53, sandersd wrote: > On 2015/02/23 23:50:20, Dirk Pranke wrote: > > On 2015/02/23 23:49:33, sandersd wrote: > > > I would prefer using the roll-deps tool to generate the CL description. > > > > > > lgtm. > > > > Oh, sorry, I didn't know such a thing existed. Will re-do. > > It's not important enough to be worth re-doing all the trybots, it just makes it > easy to find out what new patches are in the roll. You could also run the script and just copy the results to the description, assuming the DEPS change is the same.
ddorwin@chromium.org changed reviewers: - ddorwin@chromium.org
dpranke@chromium.org changed reviewers: + ddorwin@chromium.org
ddorwin@chromium.org changed reviewers: - ddorwin@chromium.org
dpranke@chromium.org changed reviewers: + ddorwin@chromium.org
ddorwin@chromium.org changed reviewers: - ddorwin@chromium.org
Done. Please take another look?
On 2015/02/23 23:59:02, Dirk Pranke wrote: > Done. Please take another look? Perfect, lgtm.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938223003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/176685b64deddd41f1b4ac40083ad24bc17af564 Cr-Commit-Position: refs/heads/master@{#317706} |