Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 938223002: [Smart Lock] Add a description for the promo notification histogram. (Closed)

Created:
5 years, 10 months ago by Ilya Sherman
Modified:
5 years, 10 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Add a description for the promo notification histogram. BUG=450508 TEST=none R=tengs@chromium.org Committed: https://crrev.com/800bd1ef4666b67c62f864bb3e6b67b05f1cbc1c Cr-Commit-Position: refs/heads/master@{#317981}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ilya Sherman
5 years, 10 months ago (2015-02-19 23:17:46 UTC) #1
Tim Song
lgtm
5 years, 10 months ago (2015-02-23 19:33:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938223002/1
5 years, 10 months ago (2015-02-23 19:35:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61866)
5 years, 10 months ago (2015-02-23 19:39:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938223002/20001
5 years, 10 months ago (2015-02-25 01:55:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 05:03:08 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 05:04:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/800bd1ef4666b67c62f864bb3e6b67b05f1cbc1c
Cr-Commit-Position: refs/heads/master@{#317981}

Powered by Google App Engine
This is Rietveld 408576698