Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 938193003: Add some metrics for printing with extension (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some metrics for printing with extension For now just recording user action for printing with extension and page count for issued print requests. Also, add missing histogram for page count when printing with privet. BUG=None Committed: https://crrev.com/0d79959841f0e42c720ea86f15e73c5bc0824734 Cr-Commit-Position: refs/heads/master@{#317460}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 2 chunks +4 lines, -1 line 1 comment Download
M tools/metrics/histograms/histograms.xml View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tbarzic
5 years, 10 months ago (2015-02-20 18:09:32 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 10 months ago (2015-02-20 18:13:10 UTC) #3
Ilya Sherman
LGTM, thanks. https://codereview.chromium.org/938193003/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/938193003/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode889 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:889: page_count); I bet that UMA_HISTOGRAM_COUNTS_100 or _10000 ...
5 years, 10 months ago (2015-02-21 00:26:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938193003/1
5 years, 10 months ago (2015-02-21 00:27:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-21 00:50:23 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:51:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d79959841f0e42c720ea86f15e73c5bc0824734
Cr-Commit-Position: refs/heads/master@{#317460}

Powered by Google App Engine
This is Rietveld 408576698