Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: mojo/apps/js/threading.cc

Issue 93813002: Implement gin::ObjectTemplateBuilder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: asdf Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/test/gtest.cc ('k') | mojo/public/bindings/js/core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/apps/js/threading.cc
diff --git a/mojo/apps/js/threading.cc b/mojo/apps/js/threading.cc
index 09536cd25b1be981d15bf01037f38e623db43c0c..e86c6e4c4c413a4b1a49c0416d1b0c474993dcc5 100644
--- a/mojo/apps/js/threading.cc
+++ b/mojo/apps/js/threading.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/message_loop/message_loop.h"
#include "gin/function_template.h"
+#include "gin/object_template_builder.h"
#include "gin/per_isolate_data.h"
#include "mojo/public/bindings/js/handle.h"
@@ -31,9 +32,10 @@ v8::Local<v8::ObjectTemplate> Threading::GetTemplate(v8::Isolate* isolate) {
&g_wrapper_info);
if (templ.IsEmpty()) {
- templ = v8::ObjectTemplate::New();
- templ->Set(gin::StringToSymbol(isolate, "quit"),
- gin::CreateFunctionTemplate(isolate, base::Bind(Quit)));
+ templ = gin::ObjectTemplateBuilder(isolate)
+ .SetMethod("quit", Quit)
+ .Build();
+
data->SetObjectTemplate(&g_wrapper_info, templ);
}
« no previous file with comments | « gin/test/gtest.cc ('k') | mojo/public/bindings/js/core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698