content/shell/browser/layout_test/layout_test_push_messaging_service.cc - Issue 938123002: Push API: Add and cleanup UMA logging for unregister/get/delivery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.cc

Issue 938123002: Push API: Add and cleanup UMA logging for unregister/get/delivery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@incognito

Patch Set: Update tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/push_messaging_status.cc ('K') | « content/public/common/push_messaging_status.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_push_messaging_service.cc

diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.cc b/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

index 491d804dc8df2b03b544ab2e4cf2f93ba97bd301..e283e0dda9eaca6b3419ca1e134fd037f911a2b3 100644

--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.cc

@@ -70,7 +70,7 @@ void LayoutTestPushMessagingService::Unregister(

const std::string& sender_id,

bool retry_on_failure,

const UnregisterCallback& callback) {

- callback.Run(PUSH_UNREGISTRATION_STATUS_SUCCESS_UNREGISTER);

+ callback.Run(PUSH_UNREGISTRATION_STATUS_SUCCESS_UNREGISTERED);

}

} // namespace content

« content/public/common/push_messaging_status.cc ('K') | « content/public/common/push_messaging_status.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »