Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/services/gcm/push_messaging_browsertest.cc

Issue 938123002: Push API: Add and cleanup UMA logging for unregister/get/delivery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@incognito
Patch Set: Update tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/push_messaging_browsertest.cc
diff --git a/chrome/browser/services/gcm/push_messaging_browsertest.cc b/chrome/browser/services/gcm/push_messaging_browsertest.cc
index 1eeb7bf5d1de205c013f3c912c6553c8d07e6727..3158ce730401d995810097406bc57a4aaf600f70 100644
--- a/chrome/browser/services/gcm/push_messaging_browsertest.cc
+++ b/chrome/browser/services/gcm/push_messaging_browsertest.cc
@@ -735,12 +735,12 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, UnregisterNetworkError) {
gcm_service()->AddExpectedUnregisterResponse(GCMClient::NETWORK_ERROR);
ASSERT_TRUE(RunScript("unregister()", &script_result));
- EXPECT_EQ("unregister error: "
- "NetworkError: Failed to connect to the push server.",
+ EXPECT_EQ("unregister error: NetworkError: "
+ "Unregistration failed - could not connect to push server",
script_result);
}
-IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, UnregisterUnknownError) {
+IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, UnregisterAbortError) {
if (!IsPushSupported())
return;
@@ -752,8 +752,8 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, UnregisterUnknownError) {
ASSERT_TRUE(RunScript("unregister()", &script_result));
EXPECT_EQ("unregister error: "
- "UnknownError: Unexpected error while trying to unregister from the"
- " push server.", script_result);
+ "AbortError: Unregistration failed - push service error",
+ script_result);
}
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698