Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938123002: Push API: Add and cleanup UMA logging for unregister/get/delivery. (Closed)

Created:
5 years, 10 months ago by johnme
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, zea+watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@incognito
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: Add and cleanup UMA logging for unregister/get/delivery. Cleans up error names for push messaging, and adds UMA tracking for Unregister and GetRegistration calls, as well as for incoming push message delivery (these supplement the existing UMA for registration and whether notifications are shown). BUG=401438 Committed: https://crrev.com/452556f229324f7ce10e08a6ffa74c24bfe60a34 Cr-Commit-Position: refs/heads/master@{#317317}

Patch Set 1 #

Patch Set 2 : Add delivery UMA #

Patch Set 3 : Update tests #

Total comments: 12

Patch Set 4 : Addressed review comments #

Patch Set 5 : Fix Android compile #

Patch Set 6 : Fix Android compile again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -113 lines) Patch
M chrome/browser/services/gcm/push_messaging_browsertest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_service_impl.cc View 1 2 3 4 5 5 chunks +42 lines, -27 lines 0 comments Download
M content/browser/push_messaging/push_messaging_message_filter.cc View 1 2 3 4 5 12 chunks +75 lines, -46 lines 0 comments Download
M content/public/common/push_messaging_status.h View 1 2 3 3 chunks +67 lines, -32 lines 0 comments Download
M content/public/common/push_messaging_status.cc View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_push_messaging_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +63 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
johnme
creis@chromium.org: Please review changes in content/public/ and content/shell/ isherman@chromium.org: Please review histograms.xml mvanouwerkerk@chromium.org: Please review ...
5 years, 10 months ago (2015-02-19 20:52:18 UTC) #2
Ilya Sherman
histograms LGTM https://codereview.chromium.org/938123002/diff/40001/chrome/browser/services/gcm/push_messaging_service_impl.cc File chrome/browser/services/gcm/push_messaging_service_impl.cc (right): https://codereview.chromium.org/938123002/diff/40001/chrome/browser/services/gcm/push_messaging_service_impl.cc#newcode66 chrome/browser/services/gcm/push_messaging_service_impl.cc:66: } nit: Please leave a blank line ...
5 years, 10 months ago (2015-02-19 21:01:45 UTC) #3
Charlie Reis
content/public and content/shell LGTM with nits. https://codereview.chromium.org/938123002/diff/40001/content/public/common/push_messaging_status.h File content/public/common/push_messaging_status.h (right): https://codereview.chromium.org/938123002/diff/40001/content/public/common/push_messaging_status.h#newcode50 content/public/common/push_messaging_status.h:50: PUSH_REGISTRATION_STATUS_INCOGNITO_SERVICE_NOT_AVAILABLE_PERMISSION_DENIED = nit: ...
5 years, 10 months ago (2015-02-19 21:30:43 UTC) #4
Michael van Ouwerkerk
lgtm with nit https://codereview.chromium.org/938123002/diff/40001/content/public/common/push_messaging_status.cc File content/public/common/push_messaging_status.cc (right): https://codereview.chromium.org/938123002/diff/40001/content/public/common/push_messaging_status.cc#newcode56 content/public/common/push_messaging_status.cc:56: return "Unregistration successful - a network ...
5 years, 10 months ago (2015-02-20 11:05:57 UTC) #5
johnme
Addressed review comments - thanks all :) https://codereview.chromium.org/938123002/diff/40001/chrome/browser/services/gcm/push_messaging_service_impl.cc File chrome/browser/services/gcm/push_messaging_service_impl.cc (right): https://codereview.chromium.org/938123002/diff/40001/chrome/browser/services/gcm/push_messaging_service_impl.cc#newcode66 chrome/browser/services/gcm/push_messaging_service_impl.cc:66: } On ...
5 years, 10 months ago (2015-02-20 11:34:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938123002/60001
5 years, 10 months ago (2015-02-20 11:35:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/44702)
5 years, 10 months ago (2015-02-20 12:04:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938123002/80001
5 years, 10 months ago (2015-02-20 12:37:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/4013)
5 years, 10 months ago (2015-02-20 13:24:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938123002/100001
5 years, 10 months ago (2015-02-20 13:38:13 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-20 14:45:58 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 14:46:46 UTC) #19
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/452556f229324f7ce10e08a6ffa74c24bfe60a34
Cr-Commit-Position: refs/heads/master@{#317317}

Powered by Google App Engine
This is Rietveld 408576698