Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 938103002: Change pepper websocket port check to use EffectiveIntPort. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change pepper websocket port check to use EffectiveIntPort. This will attempt to convert unspecified ports (-1) to the default at least, before checking. The check has gotten stricter and now only allows ports between 0 and N, etc. BUG=458443 TEST=manual for now (NaCl SDK websocket example) -- need to figure out how to get non-ephemeral test port Committed: https://crrev.com/fed1369701b19b6acce2f4ec946f3c3e189beb55 Cr-Commit-Position: refs/heads/master@{#317146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/pepper/pepper_websocket_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-19 18:57:59 UTC) #2
dmichael (off chromium)
lgtm, thanks for figuring this out!
5 years, 10 months ago (2015-02-19 19:10:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938103002/1
5 years, 10 months ago (2015-02-19 21:28:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 22:24:07 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 22:24:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fed1369701b19b6acce2f4ec946f3c3e189beb55
Cr-Commit-Position: refs/heads/master@{#317146}

Powered by Google App Engine
This is Rietveld 408576698