Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938093002: Remove dump-render-tree/PNG paged overflow tests from fast/overflow/ (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
Reviewers:
andersr
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove dump-render-tree/PNG paged overflow tests from fast/overflow/ There are already enough reftests for such things in fast/pagination/ to ensure coverage, with the exception of column-gap tests, but support for column-gap on paged containers should be removed anyway; see crbug.com/460106 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3165 lines) Patch
D LayoutTests/fast/overflow/paged-x-div.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/overflow/paged-x-div-with-column-gap.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/overflow/paged-x-on-root.html View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/overflow/paged-x-with-column-gap.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/overflow/paged-y-div.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/overflow/paged-y-on-root.html View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/android/fast/overflow/paged-x-div-with-column-gap-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/platform/android/fast/overflow/paged-x-on-root-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/platform/android/fast/overflow/paged-x-with-column-gap-expected.txt View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/platform/android/fast/overflow/paged-y-on-root-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-x-div-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-x-div-with-column-gap-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-x-on-root-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-x-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-x-with-column-gap-expected.txt View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-y-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-y-div-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/overflow/paged-y-on-root-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/platform/mac-lion/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/overflow/paged-x-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/virtual/slimmingpaint/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/virtual/slimmingpaint/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/virtual/slimmingpaint/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/virtual/slimmingpaint/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/overflow/paged-x-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-x-div-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-x-div-with-column-gap-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-x-on-root-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-x-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-x-with-column-gap-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-y-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-y-div-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/overflow/paged-y-on-root-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-x-div-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-x-div-with-column-gap-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-x-on-root-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-y-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-y-div-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/fast/overflow/paged-y-on-root-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-x-div-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-x-div-with-column-gap-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-x-on-root-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-x-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-x-with-column-gap-expected.txt View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-y-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-y-div-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/overflow/paged-y-on-root-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-x-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-x-div-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-x-div-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-x-div-with-column-gap-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-x-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-x-on-root-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-x-with-column-gap-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-x-with-column-gap-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-y-div-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-y-div-expected.txt View 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-y-on-root-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/overflow/paged-y-on-root-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-19 17:58:39 UTC) #1
andersr
lgtm
5 years, 10 months ago (2015-02-20 15:10:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938093002/1
5 years, 10 months ago (2015-02-20 16:47:10 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 22:28:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190596

Powered by Google App Engine
This is Rietveld 408576698