Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938043002: ChromeOS: Switch timezone auto update ON by default. (Closed)

Created:
5 years, 10 months ago by Alexander Alekseev
Modified:
5 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Switch timezone auto update ON by default. BUG=439239 TEST=manual Committed: https://crrev.com/01c62ce45148af7b058e0341765bc0e82b18dbb9 Cr-Commit-Position: refs/heads/master@{#317063}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/preferences.cc View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
Alexander Alekseev
Please review.
5 years, 10 months ago (2015-02-19 15:57:36 UTC) #2
Nikita (slow)
https://codereview.chromium.org/938043002/diff/1/chrome/browser/chromeos/preferences.cc File chrome/browser/chromeos/preferences.cc (right): https://codereview.chromium.org/938043002/diff/1/chrome/browser/chromeos/preferences.cc#newcode323 chrome/browser/chromeos/preferences.cc:323: user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); This should be syncable.
5 years, 10 months ago (2015-02-19 16:34:02 UTC) #3
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-19 16:38:29 UTC) #4
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-19 16:38:34 UTC) #6
Alexander Alekseev
https://codereview.chromium.org/938043002/diff/1/chrome/browser/chromeos/preferences.cc File chrome/browser/chromeos/preferences.cc (right): https://codereview.chromium.org/938043002/diff/1/chrome/browser/chromeos/preferences.cc#newcode323 chrome/browser/chromeos/preferences.cc:323: user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); On 2015/02/19 16:34:01, Nikita wrote: > This should ...
5 years, 10 months ago (2015-02-19 16:38:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938043002/1
5 years, 10 months ago (2015-02-19 16:39:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 17:03:21 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 17:04:20 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/01c62ce45148af7b058e0341765bc0e82b18dbb9
Cr-Commit-Position: refs/heads/master@{#317063}

Powered by Google App Engine
This is Rietveld 408576698