content/shell/renderer/test_runner/mock_presentation_service.cc - Issue 938033002: Fix Presentation API mocks: do not eagerly drop clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/mock_presentation_service.cc

Issue 938033002: Fix Presentation API mocks: do not eagerly drop clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/test_runner/mock_presentation_service.cc

diff --git a/content/shell/renderer/test_runner/mock_presentation_service.cc b/content/shell/renderer/test_runner/mock_presentation_service.cc

index 3c34999de8b634328b68f7202c06598037767727..769d05eda821d8e837d1842755b3d366e65dfad9 100644

--- a/content/shell/renderer/test_runner/mock_presentation_service.cc

+++ b/content/shell/renderer/test_runner/mock_presentation_service.cc

@@ -28,8 +28,6 @@ void MockPresentationService::SetScreenAvailability(bool available) {

}

void MockPresentationService::Reset() {

- FOR_EACH_OBSERVER(MockPresentationClient, presentation_clients_, Reset());

whywhat 2015/02/19 14:30:35 I think you need to leave this line as presentatio

mlamouri (slow - plz ping) 2015/02/19 14:44:31 Indeed. Didn't mean to remove it.

- presentation_clients_.Clear();

screen_availability_ = false;

}

« no previous file with comments | « content/shell/renderer/test_runner/mock_presentation_client.cc ('k') | no next file » | no next file with comments »