Fix Presentation API mocks: do not eagerly drop clients.

Fix Presentation API mocks: do not drop eagerly drop clients.

BUG=412331
Committed: https://crrev.com/4ff204b8d2637af0abd8a05485e5941af8ef4271
Cr-Commit-Position: refs/heads/master@{#317057}

[mlamouri (slow - plz ping), 2015-02-19 14:07:53]

mlamouri@chromium.org changed reviewers:
+ whyyvod@chromium.org

[mlamouri (slow - plz ping), 2015-02-19 14:08:26]

mlamouri@chromium.org changed reviewers:
+ dpranke@chromium.org

[mlamouri (slow - plz ping), 2015-02-19 14:08:26]

mlamouri@chromium.org changed required reviewers:
+ dpranke@chromium.org

[mlamouri (slow - plz ping), 2015-02-19 14:20:57]

mlamouri@chromium.org changed reviewers:
+ avayvod@chromium.org
- whyyvod@chromium.org

[whywhat, 2015-02-19 14:30:35]

lgtm

https://codereview.chromium.org/938033002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_presentation_service.cc (left):

https://codereview.chromium.org/938033002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_presentation_service.cc:31:
FOR_EACH_OBSERVER(MockPresentationClient, presentation_clients_, Reset());
I think you need to leave this line as presentation_clients_ need to reset the
availability state between the tests.

[whywhat, 2015-02-19 14:32:32]

avayvod@chromium.org changed reviewers:
+ mkwst@chromium.org
- dpranke@chromium.org

[whywhat, 2015-02-19 14:32:32]

avayvod@chromium.org changed required reviewers:
- dpranke@chromium.org

[mlamouri (slow - plz ping), 2015-02-19 14:44:12]

New patchsets have been uploaded after l-g-t-m from avayvod@chromium.org

[mlamouri (slow - plz ping), 2015-02-19 14:44:31]

mkwst@, PTAL

https://codereview.chromium.org/938033002/diff/1/content/shell/renderer/test_...
File content/shell/renderer/test_runner/mock_presentation_service.cc (left):

https://codereview.chromium.org/938033002/diff/1/content/shell/renderer/test_...
content/shell/renderer/test_runner/mock_presentation_service.cc:31:
FOR_EACH_OBSERVER(MockPresentationClient, presentation_clients_, Reset());
On 2015/02/19 at 14:30:35, whywhat wrote:
> I think you need to leave this line as presentation_clients_ need to reset the
availability state between the tests.

Indeed. Didn't mean to remove it.

[Mike West, 2015-02-19 15:12:42]

LGTM.

[mlamouri (slow - plz ping), 2015-02-19 15:34:56]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-02-19 15:35:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938033002/20001

[commit-bot: I haz the power, 2015-02-19 16:02:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-19 16:02:55]

Patchset 2 (id:??) landed as
https://crrev.com/4ff204b8d2637af0abd8a05485e5941af8ef4271
Cr-Commit-Position: refs/heads/master@{#317057}

[bungeman-skia, 2015-02-19 19:22:12]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/940783003/ by bungeman@google.com.

The reason for reverting is: This change appears to be causing failures in
running layout tests ('webkit_tests' step) of Windows 7 and Linux debug builds.
See
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/bu...
or
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/bu...
..

[bungeman-skia, 2015-02-19 21:05:25]

On 2015/02/19 19:22:12, bungeman1 wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/940783003/ by mailto:bungeman@google.com.
> 
> The reason for reverting is: This change appears to be causing failures in
> running layout tests ('webkit_tests' step) of Windows 7 and Linux debug
builds.
> See
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/bu...
> or
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/bu...
> ..

After reverting, the affected bots are now able to proceed past the previously
observed crashes.
Please be sure that when this re-lands to try (at least) the linux_blink_dbg
bot.