Fixed Lithium environment generation bug for captured objects (created

Fixed Lithium environment generation bug for captured objects (created
by escape analysis). Added several tests that expose the bug.

Summary:
LCodegen::AddToTranslation assumes that Lithium environments are
generated by depth-first traversal, but LChunkBuilder::CreateEnvironment
was generating them in breadth-first fashion. This fixes the
CreateEnvironment to traverse the captured objects depth-first.

Note:
It might be worth considering representing LEnvironment by a list
with the same order as the serialized translation representation
rather than having two lists with a subtle relationship between
them (and then serialize in a slightly different order again).

R=titzer@chromium.org, mstarzinger@chromium.org
LOG=N
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=18470

[titzer, 2013-12-20 13:38:57]

Even though we aren't officially on the hook for MIPS, this change seems
sufficiently mechanical that we should go ahead and do it in this CL, I think.

https://codereview.chromium.org/93803003/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

https://codereview.chromium.org/93803003/diff/1/src/ia32/lithium-ia32.cc#newc...
src/ia32/lithium-ia32.cc:1087: ZoneList<HValue*>* objects_to_materialize,
LEnvironment* result) {
AFAICT, this method is an exact duplicate on all the platforms. The only thing
is that it uses the UseAny method from the LChunkBuilder class, which is a
platform-specific class (i.e there is no platform-independent definition of this
class).

Would it be possible to factor this out into a platform-independent method that
takes functions to manipulate the platform-dependent LChunkBuilder (e.g. AddUse,
etc)?

That could be a real code savings.

[Jarin, 2013-12-20 16:39:10]

I have moved the common code to a newly created super class. Does it look
better?

[titzer, 2014-01-07 09:17:40]

lgtm

[Jarin, 2014-01-07 14:36:42]

Committed patchset #2 manually as r18470 (presubmit successful).

[Michael Starzinger, 2014-01-07 14:38:35]

LGTM. Nice catch. I especially like the factoring out part.

https://codereview.chromium.org/93803003/diff/40001/src/lithium.cc
File src/lithium.cc (right):

https://codereview.chromium.org/93803003/diff/40001/src/lithium.cc#newcode535
src/lithium.cc:535: //   LEnvironment::Add*Object methods), we store the lengths
(number
nit: Indentation of comments is off.