Index: tools/release/test_scripts.py |
diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py |
index 3beddfd936cc5ebe8b152c6ad442aa66ceceec5a..92160476a300a8a89bd563371907d62a1df4bdf2 100644 |
--- a/tools/release/test_scripts.py |
+++ b/tools/release/test_scripts.py |
@@ -989,15 +989,25 @@ git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@123456 123 |
""" |
- def testChromiumRoll(self): |
- googlers_mapping_py = "%s-mapping.py" % TEST_CONFIG["PERSISTFILE_BASENAME"] |
- with open(googlers_mapping_py, "w") as f: |
- f.write(""" |
-def list_to_dict(entries): |
- return {"g_name@google.com": "c_name@chromium.org"} |
-def get_list(): |
- pass""") |
+ ROLL_COMMIT_MSG = """Update V8 to version 3.22.4 (based on abc). |
+ |
+Summary of changes available at: |
+https://chromium.googlesource.com/v8/v8/+log/last_rol..abc |
+ |
+Please assign any issues to the V8 specialty sheriffs of one of the |
+following categories: |
+ |
+Stability: jkummerow@chromium.org |
+Performance: bmeurer@chromium.org, mvstanton@chromium.org |
+Clusterfuzz: jarin@chromium.org, mstarzinger@chromium.org |
+Please CC hablich@chromium.org on all issues. |
+ |
+Assign remaining issues to the V8 sheriff g_name@chromium.org |
+ |
+TBR=g_name@chromium.org,reviewer@chromium.org""" |
+ |
+ def testChromiumRoll(self): |
# Setup fake directory structures. |
TEST_CONFIG["CHROMIUM"] = self.MakeEmptyTempDirectory() |
TextToFile("", os.path.join(TEST_CONFIG["CHROMIUM"], ".git")) |
@@ -1035,13 +1045,9 @@ def get_list(): |
Cmd("git fetch origin", ""), |
Cmd("git new-branch v8-roll-push_hash", "", cwd=chrome_dir), |
Cmd("roll-dep v8 push_hash", "rolled", cb=WriteDeps, cwd=chrome_dir), |
- Cmd(("git commit -am \"Update V8 to version 3.22.4 " |
- "(based on abc).\n\n" |
- "Summary of changes available at:\n" |
- "https://chromium.googlesource.com/v8/v8/+log/last_rol..abc\n\n" |
- "Please reply to the V8 sheriff c_name@chromium.org in " |
- "case of problems.\n\nTBR=c_name@chromium.org\" " |
- "--author \"author@chromium.org <author@chromium.org>\""), |
+ Cmd(("git commit -am \"%s\" " |
+ "--author \"author@chromium.org <author@chromium.org>\"" % |
+ self.ROLL_COMMIT_MSG), |
"", cwd=chrome_dir), |
Cmd("git cl upload --send-mail --email \"author@chromium.org\" -f", "", |
cwd=chrome_dir), |
@@ -1049,7 +1055,7 @@ def get_list(): |
self.Expect(expectations) |
args = ["-a", "author@chromium.org", "-c", chrome_dir, |
- "--sheriff", "--googlers-mapping", googlers_mapping_py, |
+ "--sheriff", |
"-r", "reviewer@chromium.org", |
"--last-roll", "last_roll_hsh"] |
ChromiumRoll(TEST_CONFIG, self).Run(args) |