Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: tools/release/chromium_roll.py

Issue 938023002: Add sheriff details to roll commit message. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/release/chromium_roll.py
diff --git a/tools/release/chromium_roll.py b/tools/release/chromium_roll.py
index 8a3ff4a0a7c8695dc1ff43a50cbb13a27669780d..42035a8135582cb185fdcaf67f4d4911306f78d9 100755
--- a/tools/release/chromium_roll.py
+++ b/tools/release/chromium_roll.py
@@ -14,6 +14,18 @@ ROLL_SUMMARY = ("Summary of changes available at:\n"
"https://chromium.googlesource.com/v8/v8/+log/%s..%s")
+SPECIALTY_SHERIFF_MSG = (
+"""Please assign any issues to the V8 specialty sheriffs of one of the
+following categories:
+
+Stability: jkummerow@chromium.org
+Performance: bmeurer@chromium.org, mvstanton@chromium.org
+Clusterfuzz: jarin@chromium.org, mstarzinger@chromium.org
+
+Please CC hablich@chromium.org on all issues.""")
+
+GENERALIST_SHERIFF_MSG = "Assign remaining issues to the V8 sheriff %s"
+
class Preparation(Step):
MESSAGE = "Preparation."
@@ -93,9 +105,11 @@ class UploadCL(Step):
message.append(
ROLL_SUMMARY % (self["last_rolled_base"][:8], self["push_base"][:8]))
+ message.append(SPECIALTY_SHERIFF_MSG)
+
if self["sheriff"]:
- message.append("Please reply to the V8 sheriff %s in case of problems."
- % self["sheriff"])
+ message.append(GENERALIST_SHERIFF_MSG % self["sheriff"])
+
message.append("TBR=%s" % self._options.reviewer)
self.GitCommit("\n\n".join(message),
author=self._options.author,

Powered by Google App Engine
This is Rietveld 408576698