Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: tools/release/chromium_roll.py

Issue 938023002: Add sheriff details to roll commit message. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Link to instructions Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/release/auto_roll.py ('k') | tools/release/common_includes.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 the V8 project authors. All rights reserved. 2 # Copyright 2014 the V8 project authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import os 7 import os
8 import sys 8 import sys
9 9
10 from common_includes import * 10 from common_includes import *
11 11
12 12
13 ROLL_SUMMARY = ("Summary of changes available at:\n" 13 ROLL_SUMMARY = ("Summary of changes available at:\n"
14 "https://chromium.googlesource.com/v8/v8/+log/%s..%s") 14 "https://chromium.googlesource.com/v8/v8/+log/%s..%s")
15 15
16 16
17 ISSUE_MSG = (
18 """Please follow these instructions for assigning/CC'ing issues:
19 https://code.google.com/p/v8-wiki/wiki/TriagingIssues""")
20
17 class Preparation(Step): 21 class Preparation(Step):
18 MESSAGE = "Preparation." 22 MESSAGE = "Preparation."
19 23
20 def RunStep(self): 24 def RunStep(self):
21 # Update v8 remote tracking branches. 25 # Update v8 remote tracking branches.
22 self.GitFetchOrigin() 26 self.GitFetchOrigin()
23 27
24 28
25 class DetectLastPush(Step): 29 class DetectLastPush(Step):
26 MESSAGE = "Detect commit ID of last release." 30 MESSAGE = "Detect commit ID of last release."
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 "roll-dep", "v8 %s" % self["last_push"], 90 "roll-dep", "v8 %s" % self["last_push"],
87 cwd=self._options.chromium) is None: 91 cwd=self._options.chromium) is None:
88 self.Die("Failed to create deps for %s" % self["last_push"]) 92 self.Die("Failed to create deps for %s" % self["last_push"])
89 93
90 message = [] 94 message = []
91 message.append("Update V8 to %s." % self["push_title"].lower()) 95 message.append("Update V8 to %s." % self["push_title"].lower())
92 96
93 message.append( 97 message.append(
94 ROLL_SUMMARY % (self["last_rolled_base"][:8], self["push_base"][:8])) 98 ROLL_SUMMARY % (self["last_rolled_base"][:8], self["push_base"][:8]))
95 99
96 if self["sheriff"]: 100 message.append(ISSUE_MSG)
97 message.append("Please reply to the V8 sheriff %s in case of problems." 101
98 % self["sheriff"])
99 message.append("TBR=%s" % self._options.reviewer) 102 message.append("TBR=%s" % self._options.reviewer)
100 self.GitCommit("\n\n".join(message), 103 self.GitCommit("\n\n".join(message),
101 author=self._options.author, 104 author=self._options.author,
102 cwd=self._options.chromium) 105 cwd=self._options.chromium)
103 if not self._options.dry_run: 106 if not self._options.dry_run:
104 self.GitUpload(author=self._options.author, 107 self.GitUpload(author=self._options.author,
105 force=True, 108 force=True,
106 cq=self._options.use_commit_queue, 109 cq=self._options.use_commit_queue,
107 cwd=self._options.chromium) 110 cwd=self._options.chromium)
108 print "CL uploaded." 111 print "CL uploaded."
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 SwitchChromium, 173 SwitchChromium,
171 UpdateChromiumCheckout, 174 UpdateChromiumCheckout,
172 UploadCL, 175 UploadCL,
173 SwitchV8, 176 SwitchV8,
174 CleanUp, 177 CleanUp,
175 ] 178 ]
176 179
177 180
178 if __name__ == "__main__": # pragma: no cover 181 if __name__ == "__main__": # pragma: no cover
179 sys.exit(ChromiumRoll().Run()) 182 sys.exit(ChromiumRoll().Run())
OLDNEW
« no previous file with comments | « tools/release/auto_roll.py ('k') | tools/release/common_includes.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698