Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: tools/release/chromium_roll.py

Issue 938023002: Add sheriff details to roll commit message. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 the V8 project authors. All rights reserved. 2 # Copyright 2014 the V8 project authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import os 7 import os
8 import sys 8 import sys
9 9
10 from common_includes import * 10 from common_includes import *
11 11
12 12
13 ROLL_SUMMARY = ("Summary of changes available at:\n" 13 ROLL_SUMMARY = ("Summary of changes available at:\n"
14 "https://chromium.googlesource.com/v8/v8/+log/%s..%s") 14 "https://chromium.googlesource.com/v8/v8/+log/%s..%s")
15 15
16 16
17 SPECIALTY_SHERIFF_MSG = (
18 """Please assign any issues to the V8 specialty sheriffs of one of the
19 following categories:
20
21 Stability: jkummerow@chromium.org
22 Performance: bmeurer@chromium.org, mvstanton@chromium.org
23 Clusterfuzz: jarin@chromium.org, mstarzinger@chromium.org
24
25 Please CC hablich@chromium.org on all issues.""")
26
27 GENERALIST_SHERIFF_MSG = "Assign remaining issues to the V8 sheriff %s"
28
17 class Preparation(Step): 29 class Preparation(Step):
18 MESSAGE = "Preparation." 30 MESSAGE = "Preparation."
19 31
20 def RunStep(self): 32 def RunStep(self):
21 # Update v8 remote tracking branches. 33 # Update v8 remote tracking branches.
22 self.GitFetchOrigin() 34 self.GitFetchOrigin()
23 35
24 36
25 class DetectLastPush(Step): 37 class DetectLastPush(Step):
26 MESSAGE = "Detect commit ID of last release." 38 MESSAGE = "Detect commit ID of last release."
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 "roll-dep", "v8 %s" % self["last_push"], 98 "roll-dep", "v8 %s" % self["last_push"],
87 cwd=self._options.chromium) is None: 99 cwd=self._options.chromium) is None:
88 self.Die("Failed to create deps for %s" % self["last_push"]) 100 self.Die("Failed to create deps for %s" % self["last_push"])
89 101
90 message = [] 102 message = []
91 message.append("Update V8 to %s." % self["push_title"].lower()) 103 message.append("Update V8 to %s." % self["push_title"].lower())
92 104
93 message.append( 105 message.append(
94 ROLL_SUMMARY % (self["last_rolled_base"][:8], self["push_base"][:8])) 106 ROLL_SUMMARY % (self["last_rolled_base"][:8], self["push_base"][:8]))
95 107
108 message.append(SPECIALTY_SHERIFF_MSG)
109
96 if self["sheriff"]: 110 if self["sheriff"]:
97 message.append("Please reply to the V8 sheriff %s in case of problems." 111 message.append(GENERALIST_SHERIFF_MSG % self["sheriff"])
98 % self["sheriff"]) 112
99 message.append("TBR=%s" % self._options.reviewer) 113 message.append("TBR=%s" % self._options.reviewer)
100 self.GitCommit("\n\n".join(message), 114 self.GitCommit("\n\n".join(message),
101 author=self._options.author, 115 author=self._options.author,
102 cwd=self._options.chromium) 116 cwd=self._options.chromium)
103 if not self._options.dry_run: 117 if not self._options.dry_run:
104 self.GitUpload(author=self._options.author, 118 self.GitUpload(author=self._options.author,
105 force=True, 119 force=True,
106 cq=self._options.use_commit_queue, 120 cq=self._options.use_commit_queue,
107 cwd=self._options.chromium) 121 cwd=self._options.chromium)
108 print "CL uploaded." 122 print "CL uploaded."
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 SwitchChromium, 184 SwitchChromium,
171 UpdateChromiumCheckout, 185 UpdateChromiumCheckout,
172 UploadCL, 186 UploadCL,
173 SwitchV8, 187 SwitchV8,
174 CleanUp, 188 CleanUp,
175 ] 189 ]
176 190
177 191
178 if __name__ == "__main__": # pragma: no cover 192 if __name__ == "__main__": # pragma: no cover
179 sys.exit(ChromiumRoll().Run()) 193 sys.exit(ChromiumRoll().Run())
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698