Add sheriff details to roll commit message.

Add sheriff details to roll commit message.

Add a link with instructions about how to assign v8
issues to the chromium roll commit message.

Remove googler mapping feature as it doesn't apply anymore
to any generalist sheriff.

NOTRY=true

Committed: https://crrev.com/ef01ef07ab5e5d6d8745f9d4b4637ca90586ffdc
Cr-Commit-Position: refs/heads/master@{#26761}

[Michael Achenbach, 2015-02-19 13:51:22]

machenbach@chromium.org changed reviewers:
+ hablich@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2015-02-19 13:53:09]

PTAL. CC'ed everybody who's name is now hard-coded in the
script. If you think that is a bad idea, please speak up.

This should help getting issues faster assigned to the right
people (i.e. not always to me).

[tandrii(chromium), 2015-02-19 14:06:51]

lg-tm for all but that one comment.

https://codereview.chromium.org/938023002/diff/1/tools/release/common_include...
File tools/release/common_includes.py (right):

https://codereview.chromium.org/938023002/diff/1/tools/release/common_include...
tools/release/common_includes.py:765: # same.
I am not *yet* sure this optimism is justified. I worry, that some sensitive
info (e.g., issue, email, etc) to @chromium.org account assuming it's a Googler,
but which isn't actually a Googler. 

I.e., are we certain that in case of a mistake, strictly *public* information
will be sent to these chromium accounts?

[Jakob Kummerow, 2015-02-19 14:08:04]

Instead of generating so much text, how about adding just one line:

To find out who to CC on bugs, please see $LINK

where $LINK points to some wiki page or Google Doc (in the chromium.org domain)
where we can provide instructions with any level of detail (and update
frequency) we want?

[Michael Hablich, 2015-02-19 14:12:02]

On 2015/02/19 14:06:51, tandrii(chromium) wrote:
> lg-tm for all but that one comment.
> 
>
https://codereview.chromium.org/938023002/diff/1/tools/release/common_include...
> File tools/release/common_includes.py (right):
> 
>
https://codereview.chromium.org/938023002/diff/1/tools/release/common_include...
> tools/release/common_includes.py:765: # same.
> I am not *yet* sure this optimism is justified. I worry, that some sensitive
> info (e.g., issue, email, etc) to @chromium.org account assuming it's a
Googler,
> but which isn't actually a Googler. 
> 
> I.e., are we certain that in case of a mistake, strictly *public* information
> will be sent to these chromium accounts?

Agree. I think I know already one case-in-point (sent via IM).

[Michael Achenbach, 2015-02-19 14:14:14]

On 2015/02/19 14:08:04, Jakob wrote:
> Instead of generating so much text, how about adding just one line:
> 
> To find out who to CC on bugs, please see $LINK
> 
> where $LINK points to some wiki page or Google Doc (in the http://chromium.org
domain)
> where we can provide instructions with any level of detail (and update
> frequency) we want?

We can try that, I'm just afraid that people are generally lazy...

[Michael Hablich, 2015-02-19 14:16:08]

On 2015/02/19 14:08:04, Jakob wrote:
> Instead of generating so much text, how about adding just one line:
> 
> To find out who to CC on bugs, please see $LINK
> 
> where $LINK points to some wiki page or Google Doc (in the http://chromium.org
domain)
> where we can provide instructions with any level of detail (and update
> frequency) we want?

I would put the most important information right into the comment as it is now.
Let's make it as easy as possible for the Chrome people to assign issues to the
right person.

When we have a more sophisticated public information regarding these sheriff
duties, we can add the link or completely change the comment again.

[Michael Achenbach, 2015-02-19 14:36:28]

Patch 2 uses a link, as Jakob suggested. There is no generalist v8 sheriff which
chromium.org and google.com name don't match. Furthermore, I think it's outside
of this scripts duties to prevent errors made by the assigner. Some assigners
used the sheriff name from the top left of the waterfall before... Well, now
it's not part of this script anymore but handled in the instructions of the
external wiki page.

[tandrii(chromium), 2015-02-19 15:01:06]

lgtm

[Jakob Kummerow, 2015-02-19 15:44:32]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2015-02-19 15:44:32]

lgtm

[Michael Hablich, 2015-02-19 15:51:06]

Lgtm

[Benedikt Meurer, 2015-02-19 18:38:47]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-02-19 18:38:48]

LGTM. Great idea!

[Michael Achenbach, 2015-02-20 08:50:17]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-02-20 08:50:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/938023002/20001

[commit-bot: I haz the power, 2015-02-20 08:50:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-20 08:51:04]

Patchset 2 (id:??) landed as
https://crrev.com/ef01ef07ab5e5d6d8745f9d4b4637ca90586ffdc
Cr-Commit-Position: refs/heads/master@{#26761}