Set default page scale limits after setting webkit preferences.

Set default page scale limits after setting webkit preferences.

The default page scale limits are now set from webkit preferences so this call
was clobbering the defaults set for layout tests.

BUG=450605

[bokan, 2015-02-19 13:49:15]

bokan@chromium.org changed reviewers:
+ aelias@chromium.org

[bokan, 2015-02-19 13:49:38]

PTAL

[aelias_OOO_until_Jul13, 2015-02-19 21:03:42]

Hmm, this seems fishy.  On Android on a site without a viewport tag, the outer
viewport size should be either 980 or the content width.  The WebViewImpl size
has nothing to do with it, so I don't see why we should ever be making that
assignment.

The layout tests show their age in that they all assume an 800x600 viewport and
also expect the content to lay out at that size.  On Android the default
980-related viewporting behaviors must be somehow disabled in the layout test
environment in order to avoid all of the tests massively failing.  The value is
in an @viewport tag in Source/core/css/viewportAndroid.css loaded in by
Source/core/css/CSSDefaultStyleSheets.cpp .  This default-style-sheet loading
must be in some way disabled on Android layout tests (I haven't tracked down
where that happens though).

Likewise, I think the proper fix to this issue is to change the default minimum
scale in layout tests to be 1.  One way to elegantly address this might be to
set the defaultMinimumPageScaleFactor to 1 on all platforms, and add "min-zoom:
0.25" in viewportAndroid.css.  Give that a try.

[bokan, 2015-02-20 00:21:27]

Ah, you're right! We were and are setting the minimum scale limit in layout
tests to 1. The problem was we now clobber them since the per-platform defaults
are in webkit preferences so SetWebkitPreferences would reset it back to 0.25.

I do still think the layout size issue is a (minor) problem since we're setting
the layout size to a bogus value during initialization, even if it later gets
reset to the real size. I'll address that separately though.

[aelias_OOO_until_Jul13, 2015-02-20 00:39:58]

This patch is still based against the Blink repo, you'll need to create a new CL
(or change the repo base using some kind of git magic).

https://codereview.chromium.org/938013002/diff/20001/content/shell/renderer/l...
File content/shell/renderer/layout_test/webkit_test_runner.cc (right):

https://codereview.chromium.org/938013002/diff/20001/content/shell/renderer/l...
content/shell/renderer/layout_test/webkit_test_runner.cc:675: // Resetting the
internals object also overrides the WebPreferences, so we
This comment indicates that the resetInternalsObject call also needs to be
moved.