Issue 938003004: Make it possible to create reasonable subclasses of Event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 938003004: Make it possible to create reasonable subclasses of Event (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
hansmuller, hansmuller1

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make it possible to create reasonable subclasses of Event After this CL, authors can create custom subclasses of Event that actually work in a reasonable way, including being able to dispatch. R=hansmuller@google.com, hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fa8b1bd2b0acc32495e055b3f75076aa6c0e8434

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -10 lines)			Patch
M	sky/engine/bindings/scripts/templates/interface_dart.template	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	sky/engine/core/events/Event.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/events/Event.idl	View	2 chunks	+1 line, -5 lines	0 comments	Download
A	sky/tests/events/custom-event.sky	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A +	sky/tests/events/custom-event-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

hansmuller1

LGTM. The concstructor keyword arguments for cancelable and bubbles L particularly G.

5 years, 10 months ago (2015-02-19 22:05:21 UTC) #3

abarth-chromium

5 years, 10 months ago (2015-02-20 07:19:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fa8b1bd2b0acc32495e055b3f75076aa6c0e8434 (presubmit successful).