Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2723)

Unified Diff: chrome/browser/io_thread.cc

Issue 938003003: Add a new enable_nonblocking_io field trial param for QUIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: working Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index fc173885c80808cceaecbb40152549f9de953bf3..6d7e6c6392fb9ce3d29a4bfadebbca33c6cfab97 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -1032,6 +1032,8 @@ void IOThread::InitializeNetworkSessionParamsFromGlobals(
&params->quic_enable_truncated_connection_ids);
globals.quic_enable_connection_racing.CopyToIfSet(
&params->quic_enable_connection_racing);
+ globals.quic_enable_nonblocking_io.CopyToIfSet(
+ &params->quic_enable_nonblocking_io);
globals.quic_disable_disk_cache.CopyToIfSet(
&params->quic_disable_disk_cache);
globals.enable_quic_port_selection.CopyToIfSet(
@@ -1168,6 +1170,8 @@ void IOThread::ConfigureQuicGlobals(
ShouldQuicEnableTruncatedConnectionIds(quic_trial_params));
globals->quic_enable_connection_racing.set(
ShouldQuicEnableConnectionRacing(quic_trial_params));
+ globals->quic_enable_nonblocking_io.set(
+ ShouldQuicEnableNonblockingIO(quic_trial_params));
globals->quic_disable_disk_cache.set(
ShouldQuicDisableDiskCache(quic_trial_params));
globals->enable_quic_port_selection.set(
@@ -1375,6 +1379,14 @@ bool IOThread::ShouldQuicEnableConnectionRacing(
}
// static
+bool IOThread::ShouldQuicEnableNonblockingIO(
+ const VariationParameters& quic_trial_params) {
+ return LowerCaseEqualsASCII(
+ GetVariationParam(quic_trial_params, "enable_nonblocking_io"),
+ "true");
+}
+
+// static
bool IOThread::ShouldQuicDisableDiskCache(
const VariationParameters& quic_trial_params) {
return LowerCaseEqualsASCII(

Powered by Google App Engine
This is Rietveld 408576698