Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 938003002: bookmarks component should depend on base_i18n (Closed)

Created:
5 years, 10 months ago by Jiang Jiang
Modified:
5 years, 10 months ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bookmarks component should depend on base_i18n bookmark_index.cc, bookmark_model.cc and bookmark_utils.cc all uses functions from base_i18n. Committed: https://crrev.com/1d3287151e6ea83e386966846dfcf170f77d182b Cr-Commit-Position: refs/heads/master@{#317096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/bookmarks.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Jiang Jiang
PTAL.
5 years, 10 months ago (2015-02-19 11:59:24 UTC) #2
tfarina
Confirmed opening https://chromium.googlesource.com/chromium/src/+/master/components/bookmarks/browser/bookmark_index.cc for example. LGTM
5 years, 10 months ago (2015-02-19 14:42:46 UTC) #4
Jiang Jiang
On 2015/02/19 14:42:46, tfarina wrote: > Confirmed opening > https://chromium.googlesource.com/chromium/src/+/master/components/bookmarks/browser/bookmark_index.cc > for example. > > ...
5 years, 10 months ago (2015-02-19 14:48:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938003002/1
5 years, 10 months ago (2015-02-19 14:50:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43835)
5 years, 10 months ago (2015-02-19 14:54:57 UTC) #9
Jiang Jiang
On 2015/02/19 14:54:57, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-19 15:59:58 UTC) #10
sky
LGTM
5 years, 10 months ago (2015-02-19 17:52:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/938003002/1
5 years, 10 months ago (2015-02-19 19:19:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 19:23:05 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 19:23:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d3287151e6ea83e386966846dfcf170f77d182b
Cr-Commit-Position: refs/heads/master@{#317096}

Powered by Google App Engine
This is Rietveld 408576698