Squelch context menus on the OSX App List when both buttons are pressed.

Squelch context menus on the OSX App List when both buttons are pressed.

The apps grid uses [NSView menuForEvent:..] for its menus, so needs to
check the button state explicitly to match the behaviour of [NSButton
menu] (which isn't used, e.g., because the NSButton doesn't fill the
grid cell).

This CL adds a check to suppress the menu when the button is in the
"lit" state, which occurs when the button is being held down.

BUG=328835
TEST=Hold the left, then the right, mouse buttons over a app launcher
item. A menu shouldn't appear. Releasing the left button (without moving
the mouse cursor) will launch the item.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243391

[jackhou1, 2014-01-07 04:06:24]

lgtm

Nit: update the TEST= line in the description. It should launch when the left
mouse button is released. Also a typo "lanuch".

[tapted, 2014-01-07 05:18:16]

On 2014/01/07 04:06:24, jackhou1 wrote:
> lgtm
> 
> Nit: update the TEST= line in the description. It should launch when the left
> mouse button is released. Also a typo "lanuch".

Done.

[commit-bot: I haz the power, 2014-01-07 09:49:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/93793012/1

[commit-bot: I haz the power, 2014-01-07 13:58:15]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-07 20:50:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/93793012/1

[commit-bot: I haz the power, 2014-01-07 21:41:30]

Change committed as 243391