chrome/common/extensions/api/i18n/default_locale_handler.cc - Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/i18n/default_locale_handler.cc

Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/file_handlers/file_handlers_parser.cc ('k') | chrome/common/extensions/api/identity/oauth2_manifest_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/i18n/default_locale_handler.cc

diff --git a/chrome/common/extensions/api/i18n/default_locale_handler.cc b/chrome/common/extensions/api/i18n/default_locale_handler.cc

index 5bf98a5c09a1f5cffb562d879f70213ace8dfde6..1f0c3042aeb71b5c123b55229b017c45b1efc776 100644

--- a/chrome/common/extensions/api/i18n/default_locale_handler.cc

+++ b/chrome/common/extensions/api/i18n/default_locale_handler.cc

@@ -41,7 +41,7 @@ bool DefaultLocaleHandler::Parse(Extension* extension, base::string16* error) {

if (!extension->manifest()->GetString(keys::kDefaultLocale,

&info->default_locale) ||

!l10n_util::IsValidLocaleSyntax(info->default_locale)) {

- *error = ASCIIToUTF16(manifest_errors::kInvalidDefaultLocale);

+ *error = base::ASCIIToUTF16(manifest_errors::kInvalidDefaultLocale);

return false;

}

extension->SetManifestData(keys::kDefaultLocale, info.release());

@@ -90,7 +90,7 @@ bool DefaultLocaleHandler::Validate(

if (!base::PathExists(messages_path)) {

*error = base::StringPrintf(

"%s %s", errors::kLocalesMessagesFileMissing,

- UTF16ToUTF8(messages_path.LossyDisplayName()).c_str());

+ base::UTF16ToUTF8(messages_path.LossyDisplayName()).c_str());

return false;

}