Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 93793010: Update uses of UTF conversions in chrome/common to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // These tests make sure SettingsOverridePermission values are set correctly. 5 // These tests make sure SettingsOverridePermission values are set correctly.
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 TEST_F(SettingsOverridePermissionTest, HomePage) { 64 TEST_F(SettingsOverridePermissionTest, HomePage) {
65 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage)); 65 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage));
66 scoped_refptr<const PermissionSet> permission_set( 66 scoped_refptr<const PermissionSet> permission_set(
67 extension->GetActivePermissions()); 67 extension->GetActivePermissions());
68 68
69 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 69 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
70 std::vector<base::string16> warnings = 70 std::vector<base::string16> warnings =
71 PermissionsData::GetPermissionMessageStrings(extension.get()); 71 PermissionsData::GetPermissionMessageStrings(extension.get());
72 ASSERT_EQ(1u, warnings.size()); 72 ASSERT_EQ(1u, warnings.size());
73 EXPECT_EQ("Change your home page to: google.com/", 73 EXPECT_EQ("Change your home page to: google.com/",
74 UTF16ToUTF8(warnings[0])); 74 base::UTF16ToUTF8(warnings[0]));
75 75
76 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 76 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
77 EXPECT_FALSE(permission_set->HasAPIPermission( 77 EXPECT_FALSE(permission_set->HasAPIPermission(
78 APIPermission::kSearchProvider)); 78 APIPermission::kSearchProvider));
79 } 79 }
80 80
81 TEST_F(SettingsOverridePermissionTest, SartupPages) { 81 TEST_F(SettingsOverridePermissionTest, SartupPages) {
82 scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages)); 82 scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages));
83 scoped_refptr<const PermissionSet> permission_set( 83 scoped_refptr<const PermissionSet> permission_set(
84 extension->GetActivePermissions()); 84 extension->GetActivePermissions());
85 85
86 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 86 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
87 std::vector<base::string16> warnings = 87 std::vector<base::string16> warnings =
88 PermissionsData::GetPermissionMessageStrings(extension.get()); 88 PermissionsData::GetPermissionMessageStrings(extension.get());
89 ASSERT_EQ(1u, warnings.size()); 89 ASSERT_EQ(1u, warnings.size());
90 EXPECT_EQ("Change your start page to: startup.com/startup.html", 90 EXPECT_EQ("Change your start page to: startup.com/startup.html",
91 UTF16ToUTF8(warnings[0])); 91 base::UTF16ToUTF8(warnings[0]));
92 92
93 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 93 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
94 EXPECT_FALSE(permission_set->HasAPIPermission( 94 EXPECT_FALSE(permission_set->HasAPIPermission(
95 APIPermission::kSearchProvider)); 95 APIPermission::kSearchProvider));
96 } 96 }
97 97
98 TEST_F(SettingsOverridePermissionTest, SearchSettings) { 98 TEST_F(SettingsOverridePermissionTest, SearchSettings) {
99 scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider)); 99 scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider));
100 scoped_refptr<const PermissionSet> permission_set( 100 scoped_refptr<const PermissionSet> permission_set(
101 extension->GetActivePermissions()); 101 extension->GetActivePermissions());
102 102
103 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 103 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
104 std::vector<base::string16> warnings = 104 std::vector<base::string16> warnings =
105 PermissionsData::GetPermissionMessageStrings(extension.get()); 105 PermissionsData::GetPermissionMessageStrings(extension.get());
106 ASSERT_EQ(1u, warnings.size()); 106 ASSERT_EQ(1u, warnings.size());
107 EXPECT_EQ("Change your search settings to: google.com", 107 EXPECT_EQ("Change your search settings to: google.com",
108 UTF16ToUTF8(warnings[0])); 108 base::UTF16ToUTF8(warnings[0]));
109 109
110 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 110 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
111 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 111 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
112 } 112 }
113 113
114 TEST_F(SettingsOverridePermissionTest, All) { 114 TEST_F(SettingsOverridePermissionTest, All) {
115 scoped_refptr<Extension> extension(GetPermissionSet( 115 scoped_refptr<Extension> extension(GetPermissionSet(
116 kSearchProvider | kStartupPages | kHomepage)); 116 kSearchProvider | kStartupPages | kHomepage));
117 scoped_refptr<const PermissionSet> permission_set( 117 scoped_refptr<const PermissionSet> permission_set(
118 extension->GetActivePermissions()); 118 extension->GetActivePermissions());
(...skipping 11 matching lines...) Expand all
130 130
131 131
132 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 132 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
133 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 133 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
134 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 134 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
135 } 135 }
136 136
137 } // namespace 137 } // namespace
138 138
139 } // namespace extensions 139 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698