Format and Refactor Flip Server.

net/tools/flip_server/loadtime_measurement.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TOOLS_FLIP_SERVER_LOADTIME_MEASUREMENT_H__
 #define NET_TOOLS_FLIP_SERVER_LOADTIME_MEASUREMENT_H__
 
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
@@ skipping 26 matching lines @@
   // each url, and the test is completed.
   void ProcessRequest(const std::string& uri, std::string& output) {
     // remove "/testing/" from uri to get the action
     std::string action = uri.substr(9);
     if (pageload_html_file_.find(action) != std::string::npos) {
       read_file_to_string(pageload_html_file_.c_str(), &output);
       return;
     }
     if (action.find("get_total_iteration") == 0) {
       char buffer[16];
-      snprintf(buffer, 16, "%d", num_urls_);
+      snprintf(buffer, sizeof(buffer), "%d", num_urls_);
       output.append(buffer, strlen(buffer));
       return;
     }
     if (action.find("geturl") == 0) {
       size_t b = action.find_first_of('=');
       if (b != std::string::npos) {
         int num = atoi(action.substr(b + 1).c_str());
         if (num < num_urls_) {
           output.append(urls_[num]);
         }
       }
       return;
     }
     if (action.find("test_complete") == 0) {
       for (std::map<std::string, int>::const_iterator it = loadtimes_.begin();
-           it != loadtimes_.end(); ++it) {
+           it != loadtimes_.end();
+           ++it) {
         LOG(INFO) << it->first << " " << it->second;
       }
       loadtimes_.clear();
       output.append("OK");
       return;
     }
     if (action.find("record_page_load") == 0) {
       std::vector<std::string> query;
       split_string(action, '?', &query);
       std::vector<std::string> params;
@@ skipping 18 matching lines @@
     ssize_t read_status = read(fd, buffer, sizeof(buffer));
     while (read_status > 0) {
       output->append(buffer, static_cast<size_t>(read_status));
       do {
         read_status = read(fd, buffer, sizeof(buffer));
       } while (read_status <= 0 && errno == EINTR);
     }
     close(fd);
   }
 
-  void split_string(std::string& str, char sepa,
+  void split_string(const std::string& str,
+                    char sepa,
                     std::vector<std::string>* sub_strs) {
     size_t b = 0;
     size_t e = str.find_first_of(sepa, b);
     while (e != std::string::npos && e > b) {
       sub_strs->push_back(str.substr(b, e - b));
       b = e + 1;
       e = str.find_first_of(sepa, b);
     }
     if (b < str.size()) {
       sub_strs->push_back(str.substr(b));
     }
   }
 
   int num_urls_;
   std::vector<std::string> urls_;
   std::map<std::string, int> loadtimes_;
   const std::string pageload_html_file_;
 };
 
 #endif  // NET_TOOLS_FLIP_SERVER_LOADTIME_MEASUREMENT_H__
-