Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 93793004: Format and Refactor Flip Server. (Closed)

Created:
7 years ago by yhirano
Modified:
7 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Format and Refactor Flip Server. Apply clang-format, remove std::cout and so on. This CL does not change the behavior. BUG=NONE R=tyoshino@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239672

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+634 lines, -784 lines) Patch
M net/tools/flip_server/acceptor_thread.h View 2 chunks +14 lines, -14 lines 0 comments Download
M net/tools/flip_server/acceptor_thread.cc View 8 chunks +13 lines, -14 lines 0 comments Download
M net/tools/flip_server/constants.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/flip_server/create_listener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/flip_server/create_listener.cc View 15 chunks +69 lines, -72 lines 0 comments Download
M net/tools/flip_server/flip_config.h View 5 chunks +10 lines, -11 lines 0 comments Download
M net/tools/flip_server/flip_config.cc View 6 chunks +11 lines, -14 lines 0 comments Download
M net/tools/flip_server/flip_in_mem_edsm_server.cc View 15 chunks +83 lines, -84 lines 0 comments Download
M net/tools/flip_server/flip_test_utils.h View 1 chunk +9 lines, -8 lines 0 comments Download
M net/tools/flip_server/flip_test_utils.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/tools/flip_server/http_interface.h View 6 chunks +23 lines, -17 lines 0 comments Download
M net/tools/flip_server/http_interface.cc View 9 chunks +35 lines, -39 lines 0 comments Download
M net/tools/flip_server/http_interface_test.cc View 9 chunks +23 lines, -19 lines 0 comments Download
M net/tools/flip_server/http_message_constants.cc View 1 chunk +5 lines, -48 lines 0 comments Download
M net/tools/flip_server/loadtime_measurement.h View 4 chunks +5 lines, -4 lines 0 comments Download
M net/tools/flip_server/mem_cache.h View 5 chunks +27 lines, -32 lines 0 comments Download
M net/tools/flip_server/mem_cache.cc View 7 chunks +13 lines, -18 lines 0 comments Download
M net/tools/flip_server/mem_cache_test.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M net/tools/flip_server/output_ordering.cc View 6 chunks +14 lines, -29 lines 0 comments Download
M net/tools/flip_server/ring_buffer.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/flip_server/ring_buffer.cc View 12 chunks +14 lines, -52 lines 0 comments Download
M net/tools/flip_server/run_all_tests.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/tools/flip_server/sm_connection.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M net/tools/flip_server/sm_connection.cc View 1 2 18 chunks +73 lines, -91 lines 0 comments Download
M net/tools/flip_server/sm_interface.h View 4 chunks +12 lines, -9 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 2 3 chunks +11 lines, -6 lines 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 2 16 chunks +54 lines, -64 lines 0 comments Download
M net/tools/flip_server/spdy_interface_test.cc View 1 2 12 chunks +36 lines, -51 lines 0 comments Download
M net/tools/flip_server/spdy_ssl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/flip_server/spdy_ssl.cc View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
M net/tools/flip_server/spdy_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/flip_server/spdy_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/flip_server/streamer_interface.h View 7 chunks +26 lines, -21 lines 0 comments Download
net/tools/flip_server/streamer_interface.cc View 5 chunks +20 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yhirano
7 years ago (2013-12-06 06:55:20 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/93793004/diff/1/net/tools/flip_server/sm_connection.cc File net/tools/flip_server/sm_connection.cc (right): https://codereview.chromium.org/93793004/diff/1/net/tools/flip_server/sm_connection.cc#newcode355 net/tools/flip_server/sm_connection.cc:355: } break; put this inside braces? https://codereview.chromium.org/93793004/diff/1/net/tools/flip_server/sm_connection.cc#newcode381 net/tools/flip_server/sm_connection.cc:381: ...
7 years ago (2013-12-09 06:54:06 UTC) #2
yhirano
+rch for OWNER review. https://codereview.chromium.org/93793004/diff/1/net/tools/flip_server/sm_connection.cc File net/tools/flip_server/sm_connection.cc (right): https://codereview.chromium.org/93793004/diff/1/net/tools/flip_server/sm_connection.cc#newcode355 net/tools/flip_server/sm_connection.cc:355: } break; On 2013/12/09 06:54:06, ...
7 years ago (2013-12-09 07:41:00 UTC) #3
Ryan Hamilton
lgtm
7 years ago (2013-12-09 22:59:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/93793004/20001
7 years ago (2013-12-10 01:55:11 UTC) #5
commit-bot: I haz the power
Failed to apply patch for net/tools/flip_server/constants.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-10 01:55:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/93793004/40001
7 years ago (2013-12-10 02:31:38 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-10 05:35:46 UTC) #8
Message was sent while issue was closed.
Change committed as 239672

Powered by Google App Engine
This is Rietveld 408576698