Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 937883002: cc: Change CallFunctionForSubtree to use lambdas. (Closed)

Created:
5 years, 10 months ago by vmpstr
Modified:
5 years, 9 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Change CallFunctionForSubtree to use lambdas. This patch changes CallFunctionForSubtree from using base::Bind to using lambdas, which makes it slightly more readable at the call site. R=enne, danakj Committed: https://crrev.com/a73f18d962286f50582766e4a2939f3858a58c5c Cr-Commit-Position: refs/heads/master@{#318750}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : actual rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -115 lines) Patch
M cc/debug/debug_rect_history.cc View 1 4 chunks +12 lines, -16 lines 0 comments Download
M cc/debug/invalidation_benchmark.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/invalidation_benchmark.cc View 1 chunk +1 line, -5 lines 0 comments Download
M cc/debug/picture_record_benchmark.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/debug/picture_record_benchmark.cc View 2 chunks +1 line, -5 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark.cc View 2 chunks +1 line, -5 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 chunks +2 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 2 chunks +15 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 6 chunks +16 lines, -34 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
enne (OOO)
lgtm https://codereview.chromium.org/937883002/diff/1/cc/trees/layer_tree_host_common.h File cc/trees/layer_tree_host_common.h (right): https://codereview.chromium.org/937883002/diff/1/cc/trees/layer_tree_host_common.h#newcode209 cc/trees/layer_tree_host_common.h:209: const Function& function) { Amusingly, I'm pretty sure ...
5 years, 10 months ago (2015-02-25 19:58:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937883002/1
5 years, 10 months ago (2015-02-25 19:59:38 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/62145)
5 years, 10 months ago (2015-02-25 20:05:59 UTC) #5
danakj
https://codereview.chromium.org/937883002/diff/1/cc/trees/layer_tree_host_common.h File cc/trees/layer_tree_host_common.h (right): https://codereview.chromium.org/937883002/diff/1/cc/trees/layer_tree_host_common.h#newcode209 cc/trees/layer_tree_host_common.h:209: const Function& function) { On 2015/02/25 19:58:50, enne wrote: ...
5 years, 10 months ago (2015-02-25 20:06:31 UTC) #6
danakj
Oh this is that patch lol
5 years, 10 months ago (2015-02-25 20:06:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937883002/20001
5 years, 9 months ago (2015-03-02 17:56:56 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/1208) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-02 18:00:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937883002/40001
5 years, 9 months ago (2015-03-02 19:26:49 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-02 21:04:46 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 21:05:54 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a73f18d962286f50582766e4a2939f3858a58c5c
Cr-Commit-Position: refs/heads/master@{#318750}

Powered by Google App Engine
This is Rietveld 408576698