Issue 937863004: Revert accidental console.cc changes from 23538d3c49dfaff28e4d88b3254b7ab8cf1b6e35

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 937863004: Revert accidental console.cc changes from 23538d3c49dfaff28e4d88b3254b7ab8cf1b6e35 (Closed)

Created:
5 years, 10 months ago by jamesr

Modified:
5 years, 10 months ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert accidental console.cc changes from 23538d3c49dfaff28e4d88b3254b7ab8cf1b6e35 Somehow davemoore@ reverted a change to services/console/console.cc as part of adding new functionality to the shell. This reverts the revert. TBR=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fbdd0bcc2395d5be6aaf8a1a7b2f1a85ce52bfd2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	services/console/console.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

jamesr

5 years, 10 months ago (2015-02-19 01:30:32 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fbdd0bcc2395d5be6aaf8a1a7b2f1a85ce52bfd2 (presubmit successful).