Add AwAssets into android_webview/native/public

Add AwAssets into android_webview/native/public

This is done so that android_webview/browser doesn't need to depend on
android_webview/native

BUG=459779
Committed: https://crrev.com/a08360b39730751c5f85797bdff5b748d907c11a
Cr-Commit-Position: refs/heads/master@{#317475}

[hush (inactive), 2015-02-18 23:53:25]

hush@chromium.org changed reviewers:
+ boliu@chromium.org

[hush (inactive), 2015-02-18 23:53:26]

PTAL

[sgurun-gerrit only, 2015-02-19 00:00:58]

On 2015/02/18 23:53:26, hush wrote:
> PTAL

[sgurun-gerrit only, 2015-02-19 00:01:04]

sgurun@chromium.org changed reviewers:
+ sgurun@chromium.org

[sgurun-gerrit only, 2015-02-19 00:01:04]

https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
File android_webview/native/webview_native.gyp (right):

https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
android_webview/native/webview_native.gyp:100: 'publc/aw_assets_utils.h',
does this even compile?

[hush (inactive), 2015-02-19 00:04:43]

On 2015/02/19 00:01:04, sgurun wrote:
>
https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
> File android_webview/native/webview_native.gyp (right):
> 
>
https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
> android_webview/native/webview_native.gyp:100: 'publc/aw_assets_utils.h',
> does this even compile?

Yes. I compiled and verified the method is called.
Everything here is in native/ by default.

[hush (inactive), 2015-02-19 00:57:18]

On 2015/02/19 00:04:43, hush wrote:
> On 2015/02/19 00:01:04, sgurun wrote:
> >
>
https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
> > File android_webview/native/webview_native.gyp (right):
> > 
> >
>
https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
> > android_webview/native/webview_native.gyp:100: 'publc/aw_assets_utils.h',
> > does this even compile?
> 
> Yes. I compiled and verified the method is called.
> Everything here is in native/ by default.

You mean "public" spelling error... I'm surprised it even compiled..

[boliu, 2015-02-19 00:59:43]

On 2015/02/19 00:57:18, hush wrote:
> On 2015/02/19 00:04:43, hush wrote:
> > On 2015/02/19 00:01:04, sgurun wrote:
> > >
> >
>
https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
> > > File android_webview/native/webview_native.gyp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
> > > android_webview/native/webview_native.gyp:100: 'publc/aw_assets_utils.h',
> > > does this even compile?
> > 
> > Yes. I compiled and verified the method is called.
> > Everything here is in native/ by default.
> 
> You mean "public" spelling error... I'm surprised it even compiled..

You probably didn't gyp. Moving headers is usually ok without re-gyping

[hush (inactive), 2015-02-19 01:55:51]

On 2015/02/19 00:59:43, boliu wrote:
> On 2015/02/19 00:57:18, hush wrote:
> > On 2015/02/19 00:04:43, hush wrote:
> > > On 2015/02/19 00:01:04, sgurun wrote:
> > > >
> > >
> >
>
https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
> > > > File android_webview/native/webview_native.gyp (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/937863003/diff/1/android_webview/native/webvi...
> > > > android_webview/native/webview_native.gyp:100:
'publc/aw_assets_utils.h',
> > > > does this even compile?
> > > 
> > > Yes. I compiled and verified the method is called.
> > > Everything here is in native/ by default.
> > 
> > You mean "public" spelling error... I'm surprised it even compiled..
> 
> You probably didn't gyp. Moving headers is usually ok without re-gyping
I re-gyped...
That is not a header moving. It is actually a new header file. It is just made
to look like a move by web UI.

I just rm -rf out/ and recompiled without including my new files in any .gyp.
And the new files are explicitly picked up by the "#include" command in
aw_browser_main_parts.cc

Furthermore, I did some experiments by removing a whole bunch of .h files from
the "sources" of webview_native target. And system_webview_google_apk still
compiles and runs fine. (as long as you keep the .cc counter parts there,
otherwise you get linker errors)

Another thing I found is that gyp is very lenient towards the errors in .gyp
file "sources". You can declare non-existent files as "sources" and gyp will not
complain. You might run into linker error in the end if you try to compile. But
that's not guaranteed, which is the case of this CL.

Anyways, it is unnecessary to add the new .h file into the "sources" list of
webview_native.gyp

[sgurun-gerrit only, 2015-02-19 02:19:32]

https://codereview.chromium.org/937863003/diff/20001/android_webview/native/p...
File android_webview/native/public/aw_assets_utils.h (right):

https://codereview.chromium.org/937863003/diff/20001/android_webview/native/p...
android_webview/native/public/aw_assets_utils.h:5: #ifndef
ANDROID_WEBVIEW_NATIVE_PUBLIC_AW_ASSETS_H_
fix, seems like not named properly.

https://codereview.chromium.org/937863003/diff/20001/android_webview/native/p...
android_webview/native/public/aw_assets_utils.h:13: namespace AwAssetsUtils {
drop the plural in assets, i.e. AwAssetUtils

[hush (inactive), 2015-02-19 02:29:01]

On 2015/02/19 02:19:32, sgurun wrote:
>
https://codereview.chromium.org/937863003/diff/20001/android_webview/native/p...
> File android_webview/native/public/aw_assets_utils.h (right):
> 
>
https://codereview.chromium.org/937863003/diff/20001/android_webview/native/p...
> android_webview/native/public/aw_assets_utils.h:5: #ifndef
> ANDROID_WEBVIEW_NATIVE_PUBLIC_AW_ASSETS_H_
> fix, seems like not named properly.
> 
>
https://codereview.chromium.org/937863003/diff/20001/android_webview/native/p...
> android_webview/native/public/aw_assets_utils.h:13: namespace AwAssetsUtils {
> drop the plural in assets, i.e. AwAssetUtils

We just talked in person. It's okay to put .cc files inside public/
(content/public as an example).
This way we don't need to create a new file.

[hush (inactive), 2015-02-19 02:29:10]

Patchset #4 (id:60001) has been deleted

[hush (inactive), 2015-02-20 18:54:46]

what do you think of PS4?

[sgurun-gerrit only, 2015-02-21 01:02:59]

On 2015/02/20 18:54:46, hush wrote:
> what do you think of PS4?

lgtm

[hush (inactive), 2015-02-21 01:03:13]

The CQ bit was checked by hush@chromium.org

[commit-bot: I haz the power, 2015-02-21 01:03:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/937863003/70009

[commit-bot: I haz the power, 2015-02-21 01:22:05]

Committed patchset #4 (id:70009)

[commit-bot: I haz the power, 2015-02-21 01:22:34]

Patchset 4 (id:??) landed as
https://crrev.com/a08360b39730751c5f85797bdff5b748d907c11a
Cr-Commit-Position: refs/heads/master@{#317475}

[binjin, 2015-02-23 11:19:58]

A revert of this CL (patchset #4 id:70009) has been created in
https://codereview.chromium.org/947113002/ by binjin@chromium.org.

The reason for reverting is: Suspected to cause 'checkdeps' failures on Linux
bot:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/2099...

ERROR in
/mnt/data/b/build/slave/Linux_Tests/build/src/android_webview/browser/aw_dev_tools_manager_delegate.cc
  Illegal include: "android_webview/native/aw_contents.h"
    Because of "-android_webview" from android_webview/browser's include_rules.
.