Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 937863002: Updated GN file for data reduction proxy content tests (Closed)

Created:
5 years, 10 months ago by bengr
Modified:
5 years, 10 months ago
Reviewers:
Tima Vaisburd, sclittle
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated GN file for data reduction proxy content tests skia and mojo dependencies were missing and were thus added. BUG=459399 Committed: https://crrev.com/b5fbd6d46caa8554ab2b790a099cdb361409bb5d Cr-Commit-Position: refs/heads/master@{#316919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/data_reduction_proxy/content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bengr
PTAL
5 years, 10 months ago (2015-02-18 22:21:24 UTC) #2
sclittle
LGTM
5 years, 10 months ago (2015-02-18 22:23:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937863002/1
5 years, 10 months ago (2015-02-18 22:55:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 23:42:06 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 23:43:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5fbd6d46caa8554ab2b790a099cdb361409bb5d
Cr-Commit-Position: refs/heads/master@{#316919}

Powered by Google App Engine
This is Rietveld 408576698