Issue 937843002: roll gyp 2030:2034

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 937843002: roll gyp 2030:2034 (Closed)

Created:
5 years, 10 months ago by pcc

Modified:
5 years, 10 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

roll gyp 2030:2034 r2031: Reland "msvs/ninja win: Fix support for ImageHasSafeExceptionHandlers" r2032: msvs: Prefer x64 toolset if we are running on 64-bit r2033: Make msvs-ninja work for target-arch=x64 r2034: ninja/posix: Introduce support for arflags variable. BUG=453195 R=thakis@chromium.org Committed: https://crrev.com/02e28165702417d56496a1140ebd8440f2e6393d Cr-Commit-Position: refs/heads/master@{#316922}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

lgtm The ImageHasSafeExceptionHandlers thing caused trouble last time. If it still does, let me know, ...

5 years, 10 months ago (2015-02-18 21:52:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937843002/1

5 years, 10 months ago (2015-02-18 21:53:43 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-18 23:48:01 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/02e28165702417d56496a1140ebd8440f2e6393d
Cr-Commit-Position: refs/heads/master@{#316922}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages