Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 937823002: Plugin Placeholders: Fix "blank first menu item" bug when no mime type. (Closed)

Created:
5 years, 10 months ago by tommycli
Modified:
5 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Placeholders: Fix "blank first menu item" bug when no mime type. When the plugin params don't include a MIME type, and there is no plugin found, the first menu item will be blank. This patch just removes the first menu item if there is no mime type. BUG=354197 Committed: https://crrev.com/c2710e616b5fed15b8ae832a133f5419cfff2e39 Cr-Commit-Position: refs/heads/master@{#316903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tommycli
Hi Bernhard, PTAL. This patch fixes the 'blank first menu item' bug. See http://www.w3schools.com/html/tryit.asp?filename=tryhtml_object_plugin on ...
5 years, 10 months ago (2015-02-18 19:53:38 UTC) #2
Bernhard Bauer
lgtm
5 years, 10 months ago (2015-02-18 21:03:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/937823002/1
5 years, 10 months ago (2015-02-18 21:14:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 22:33:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 22:33:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2710e616b5fed15b8ae832a133f5419cfff2e39
Cr-Commit-Position: refs/heads/master@{#316903}

Powered by Google App Engine
This is Rietveld 408576698