third_party/android_crazy_linker/src/src/crazy_linker_globals.cpp - Issue 937813002: Close a window for a race with the system linker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_globals.cpp

Issue 937813002: Close a window for a race with the system linker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update for more review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/android_crazy_linker/src/src/crazy_linker_globals.cpp

diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_globals.cpp b/third_party/android_crazy_linker/src/src/crazy_linker_globals.cpp

index 89c4061ab7e94ded83a203e3d141afe60d8dd570..8bb5879f1031eafc99aa50e04ea407a7bad91554 100644

--- a/third_party/android_crazy_linker/src/src/crazy_linker_globals.cpp

+++ b/third_party/android_crazy_linker/src/src/crazy_linker_globals.cpp

@@ -20,7 +20,10 @@ void CreateGlobalsInstance() { g_globals = new Globals(); }

} // namespace

Globals::Globals() : search_paths_(), rdebug_() {

- pthread_mutex_init(&lock_, NULL);

+ pthread_mutexattr_t attr;

+ pthread_mutexattr_init(&attr);

+ pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);

+ pthread_mutex_init(&lock_, &attr);

search_paths_.ResetFromEnv("LD_LIBRARY_PATH");

}